[GitHub] [accumulo-website] ctubbsii commented on a diff in pull request #382: add confluence link to how-to-contribute page

["ctubbsii (via GitHub)" <gi...@apache.org>]

ctubbsii commented on code in PR #382:
URL: https://github.com/apache/accumulo-website/pull/382#discussion_r1160257439


##########
pages/how-to-contribute.md:
##########
@@ -19,16 +20,16 @@ Any questions/ideas don't hesitate to [contact us][contact].
 
 ## Accumulo Repositories
 
-| Repository         | Links                          | Description
-| -------------------| ------------------------------ | -----------
-| [Accumulo][a]      | [Contribute][ac] [Issues][ai]  | Core Project
-| [Website][w]       | [Contribute][wc] [Issues][wi]  | Source for this website
-| [Examples][e]      | [Contribute][ec] [Issues][ei]  | Example code
-| [Testing][t]       | [Contribute][tc] [Issues][ti]  | Test suites such as continuous ingest and random walk
-| [Docker][d]        | [Contribute][dc] [Issues][di]  | Source for Accumulo Docker image
-| [Wikisearch][s]    | [Contribute][sc] [Issues][si]  | Example application that indexes and queries Wikipedia data
-| [Proxy][p]         | [Issues][pi]                   | Apache Thrift service that exposes Accumulo to other languages
-| [Maven plugin][m]  | [Issues][mi]                   | Maven plugin that runs Accumulo
+| Repository         | Links                          | Description |
+| -------------------| ------------------------------ | ----------- |
+| [Accumulo][a]      | [Contribute][ac] [Issues][ai]  | Core Project |
+| [Website][w]       | [Contribute][wc] [Issues][wi]  | Source for this website |
+| [Examples][e]      | [Contribute][ec] [Issues][ei]  | Example code |
+| [Testing][t]       | [Contribute][tc] [Issues][ti]  | Test suites such as continuous ingest and random walk |
+| [Docker][d]        | [Contribute][dc] [Issues][di]  | Source for Accumulo Docker image |
+| [Wikisearch][s]    | [Contribute][sc] [Issues][si]  | Example application that indexes and queries Wikipedia data |
+| [Proxy][p]         | [Issues][pi]                   | Apache Thrift service that exposes Accumulo to other languages |
+| [Maven plugin][m]  | [Issues][mi]                   | Maven plugin that runs Accumulo |

Review Comment:
   Since these are optional, I would take it or leave it. I don't think it matters, as long as it's consistent. I think I recently fixed a few lines on the people page that were missing these, but only because all the other lines had them, not because they are needed.
   
   I'm okay if you leave this change in, but it's also fine to leave it unchanged. I don't think it matters.



##########
pages/how-to-contribute.md:
##########
@@ -62,10 +63,13 @@ Any questions/ideas don't hesitate to [contact us][contact].
 
 * **Build resources** - [Jenkins][jenkins]
 * **Releases** - [Making a release][making], [Verifying a release][verifying]
+* **Confluence** - [Accumulo Confluence Space][confluence] provides a collaboration space for design documents.  If you would like write
+access, please send a request to `dev@accumulo.apache.org` with your Confluence username.

Review Comment:
   I would characterize this as a "require" rather than a "want", because there should be an actual need. Characterizing it as a need, implies that the requester provide some answer to "why?" up front, rather than us asking it as a follow-up question. So, instead of "I want write access" (and us having to ask "for what?"), it becomes "I require write access because I want to contribute to document X".
   
   ```suggestion
   * **Confluence** - [Accumulo Confluence Space][confluence] provides a collaboration space for design documents. If you require write
   access, please [contact us][contact] with your Confluence username and request details.
   ```



##########
pages/how-to-contribute.md:
##########
@@ -8,6 +8,7 @@ Contributions are welcome to all Apache Accumulo repositories. While most contri
 there are other ways to contribute to Accumulo:
 
 * communicate on one of the [mailing lists](/contact-us/#mailing-lists)
+* participate in design discussions on [Confluence][confluence]

Review Comment:
   I would not characterize Confluence as a place for "discussions". The mailing list is for that. Confluence is for drafting/posting/commenting-on design docs.
   
   I suggest:
   
   ```suggestion
   * view/draft/comment on designs or other docs in [Confluence][confluence]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org