You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2014/11/29 03:23:12 UTC
[jira] [Resolved] (NET-554) Simplify TelnetOptionHandler class
hierarchy
[ https://issues.apache.org/jira/browse/NET-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved NET-554.
----------------------
Resolution: Fixed
URL: http://svn.apache.org/r1642392
Log:
NET-554 Simplify TelnetOptionHandler class hierarchy
Modified:
commons/proper/net/trunk/src/changes/changes.xml
commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/EchoOptionHandler.java
commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/SimpleOptionHandler.java
commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/SuppressGAOptionHandler.java
commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetOptionHandler.java
commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TerminalTypeOptionHandler.java
commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/WindowSizeOptionHandler.java
> Simplify TelnetOptionHandler class hierarchy
> --------------------------------------------
>
> Key: NET-554
> URL: https://issues.apache.org/jira/browse/NET-554
> Project: Commons Net
> Issue Type: Improvement
> Components: Telnet
> Affects Versions: 3.3
> Reporter: Sebb
> Priority: Minor
> Fix For: 3.4
>
>
> The TelnetOptionHandler class contains the following abstract methods:
> answerSubnegotiation
> startSubnegotiationLocal
> startSubnegotiationRemote
> In almost all the sub-classes, the implementation returns null.
> The code could be simplified by returning null in the parent class and dropping the sub-class implementations that just return null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)