[jira] [Commented] (FLINK-4517) scala code refactoring

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15455202#comment-15455202 ] 

ASF GitHub Bot commented on FLINK-4517:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2428
  
    I think that is the right approach. Fix stale issue as one goes across the code.
    If you want to guard issues by checkstyle, I would suggest to take one rule at a time and address the changes.
    
    Not all rules are agreed upon by all, so one rule at a time helps to do the changes that all agree upon.


> scala code refactoring
> ----------------------
>
>                 Key: FLINK-4517
>                 URL: https://issues.apache.org/jira/browse/FLINK-4517
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: shijinkui
>            Priority: Minor
>
> such as:
> 1. case class does't need `new`
> 2. case block does't need `{  ...  }`
> 3. match-case instead of isInstanceOf 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)