You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/22 11:51:12 UTC
[GitHub] [pulsar] murong00 opened a new pull request #8342: [Issue 8340] [pulsar-testclient] Provide options to specify existing topics and subscriptions
murong00 opened a new pull request #8342:
URL: https://github.com/apache/pulsar/pull/8342
### Motivation
Fixes #8340
### Modifications
- Add option `--explicit-topics` for CLI `pulsar-perf produce/consume/read` to specify existing topics.
- Add option `--explicit-subscriptions` for CLI `pulsar-perf consume` to specify existing subscriptions.
- Modify the corresponding `.md` file for these new added options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #8342: [Issue 8340] [pulsar-testclient] Provide options to specify existing topics and subscriptions
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #8342:
URL: https://github.com/apache/pulsar/pull/8342#issuecomment-757673779
Hi @murong00, any blockers for this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] murong00 commented on pull request #8342: [Issue 8340] [pulsar-testclient] Provide options to specify existing topics and subscriptions
Posted by GitBox <gi...@apache.org>.
murong00 commented on pull request #8342:
URL: https://github.com/apache/pulsar/pull/8342#issuecomment-785664207
@Anonymitaet I will close this pr and submit a new one by taking penghui's advice, I expect it can be applied to 2.7.1 if possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8342: [Issue 8340] [pulsar-testclient] Provide options to specify existing topics and subscriptions
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8342:
URL: https://github.com/apache/pulsar/pull/8342#issuecomment-728665710
move to 2.8.0 first
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8342: [Issue 8340] [pulsar-testclient] Provide options to specify existing topics and subscriptions
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8342:
URL: https://github.com/apache/pulsar/pull/8342#issuecomment-718343168
@murong00 I will remove the release/2.6.2 tag since this is a new feature and the release manager is starting to build the 2.6.2 release package. So it's better to onboard this feature in 2.7.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] murong00 commented on pull request #8342: [Issue 8340] [pulsar-testclient] Provide options to specify existing topics and subscriptions
Posted by GitBox <gi...@apache.org>.
murong00 commented on pull request #8342:
URL: https://github.com/apache/pulsar/pull/8342#issuecomment-714904577
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #8342: [Issue 8340] [pulsar-testclient] Provide options to specify existing topics and subscriptions
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #8342:
URL: https://github.com/apache/pulsar/pull/8342#issuecomment-753786926
@murong00 any progress on this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] murong00 closed pull request #8342: [Issue 8340] [pulsar-testclient] Provide options to specify existing topics and subscriptions
Posted by GitBox <gi...@apache.org>.
murong00 closed pull request #8342:
URL: https://github.com/apache/pulsar/pull/8342
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] murong00 commented on pull request #8342: [Issue 8340] [pulsar-testclient] Provide options to specify existing topics and subscriptions
Posted by GitBox <gi...@apache.org>.
murong00 commented on pull request #8342:
URL: https://github.com/apache/pulsar/pull/8342#issuecomment-753792629
> @murong00 any progress on this PR?
Need some discussion with penghui, I will try to accomplish it based on the master this week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #8342: [Issue 8340] [pulsar-testclient] Provide options to specify existing topics and subscriptions
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #8342:
URL: https://github.com/apache/pulsar/pull/8342#issuecomment-716919594
@jiazhai @codelipenghui @sijie @merlimat PTAL thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #8342: [Issue 8340] [pulsar-testclient] Provide options to specify existing topics and subscriptions
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #8342:
URL: https://github.com/apache/pulsar/pull/8342#issuecomment-785555022
@murong00 thanks for your coding work.
1. Does this apply to 2.7.1?
2. Would you like to add docs for this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org