You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by nickva <gi...@git.apache.org> on 2015/09/30 16:40:44 UTC

[GitHub] couchdb-couch pull request: Fix OS Daemons test dependency.

GitHub user nickva opened a pull request:

    https://github.com/apache/couchdb-couch/pull/109

    Fix OS Daemons test dependency.

    In isolation was failing in configuration_reader_test_
    Because fixtures/os_daemon_configer.escript was
    requesting uuids.algorithm from config application,
    which was not set up.
    
    COUCHDB-2831

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nickva/couchdb-couch 2831-os-daemons-config-test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch/pull/109.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #109
    
----
commit 2d6de972d949ca1efb4396ed475e7300675e90f5
Author: Nick Vatamaniuc <va...@gmail.com>
Date:   2015-09-30T14:37:20Z

    Fix OS Daemons test dependency.
    
    In isolation was failing in configuration_reader_test_
    Because fixtures/os_daemon_configer.escript was
    requesting uuids.algorithm from config application,
    which was not set up.
    
    COUCHDB-2831

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch pull request: Fix OS Daemons test dependency.

Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:

    https://github.com/apache/couchdb-couch/pull/109#issuecomment-144437370
  
    Previously, this config option was read from default.ini files that was loaded by config app. It seems now it's gone and config loads with empty state. While it's good to restore old behavior, it also shows how much our tests implicitly coupled with other things and these dependencies are not very clear.
    
    So it's ok to explicitly define dependency from this uuid setting here, since we don't test default algorithm here, but ability of os_daemon to read retrieve some config setting via stdio commands.
    
    +1 after address comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch pull request: Fix OS Daemons test dependency.

Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch/pull/109#discussion_r40803497
  
    --- Diff: test/couchdb_os_daemons_tests.erl ---
    @@ -41,6 +41,7 @@ setup(DName) ->
         {ok, OsDPid} = couch_os_daemons:start_link(),
         config:set("os_daemons", DName,
                          filename:join([?FIXTURESDIR, DName]), false),
    +    config:set("uuids","algorithm","sequential", false),
    --- End diff --
    
    Spaces after commas and add notice about why we need it here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch pull request: Fix OS Daemons test dependency.

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/couchdb-couch/pull/109


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---