You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2023/07/11 01:07:48 UTC
[GitHub] [spark] cloud-fan commented on a diff in pull request #41893: [SPARK-44335][SQL] SQL parser should have a SQLConf parameter instead of relying on the active conf
cloud-fan commented on code in PR #41893:
URL: https://github.com/apache/spark/pull/41893#discussion_r1259058533
##########
sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -1570,7 +1570,7 @@ class Dataset[T] private[sql](
* @since 2.0.0
*/
@scala.annotation.varargs
- def selectExpr(exprs: String*): DataFrame = sparkSession.withActive {
Review Comment:
That's a good point. It's not only about the parser, but also expression instantiations.
@yaooqinn can you fix other DF APIs to wrap with `sparkSession.withActive`? I believe there are more APIs that take a SQL string and parse it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org