[GitHub] [beam] damccorm commented on a diff in pull request #27721: Setup Java Flink runner PreCommit

["damccorm (via GitHub)" <gi...@apache.org>]

damccorm commented on code in PR #27721:
URL: https://github.com/apache/beam/pull/27721#discussion_r1277577027


##########
build.gradle.kts:
##########
@@ -241,16 +241,12 @@ tasks.register("javaPreCommit") {
   dependsOn(":runners:core-java:build")
   dependsOn(":runners:direct-java:build")
   dependsOn(":runners:extensions-java:metrics:build")
-  dependsOn(":runners:flink:1.12:build")
-  dependsOn(":runners:flink:1.12:job-server:build")
-  dependsOn(":runners:flink:1.13:build")
-  dependsOn(":runners:flink:1.13:job-server:build")
-  dependsOn(":runners:flink:1.14:build")
-  dependsOn(":runners:flink:1.14:job-server:build")
-  dependsOn(":runners:flink:1.15:build")
-  dependsOn(":runners:flink:1.15:job-server:build")
-  dependsOn(":runners:flink:1.16:build")
-  dependsOn(":runners:flink:1.16:job-server:build")
+  // lowest and highest supported flink versions
+  var flinkVersions = project.ext.get("allFlinkVersions") as Array<*>
+  dependsOn(":runners:flink:${flinkVersions[0]}:build")
+  dependsOn(":runners:flink:${flinkVersions[0]}:job-server:build")
+  dependsOn(":runners:flink:${flinkVersions[flinkVersions.size - 1]}:build")
+  dependsOn(":runners:flink:${flinkVersions[flinkVersions.size - 1]}:job-server:build")

Review Comment:
   How often are we aware of catching a java issue with flink specific tests? I'd probably vote we just move all versions into the separate suite where it can run only on flink changes. In general, I'm a big fan of smaller more targeted suites to reduce flakiness.
   
   If the flink tests would've caught a real issue, we'll still get that when the action does its normal scheduled run.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org