You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/11/29 21:37:10 UTC

[kudu-CR] [tablet] --tablet history max age sec is a runtime flag

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19286


Change subject: [tablet] --tablet_history_max_age_sec is a runtime flag
......................................................................

[tablet] --tablet_history_max_age_sec is a runtime flag

The way how --tablet_history_max_age_sec is used in
Tablet::GetTabletAncientHistoryMark() mandates a 'runtime' tag for the
flag.  That allows for using the `kudu tserver set_flag` CLI tool
without adding the --force option when updating the setting.

Change-Id: Ie2b1553325cd33953d104b5bb3e8aeb73d90642a
---
M src/kudu/tablet/tablet.cc
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/19286/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2b1553325cd33953d104b5bb3e8aeb73d90642a
Gerrit-Change-Number: 19286
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [tablet] --tablet history max age sec is a runtime flag

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19286 )

Change subject: [tablet] --tablet_history_max_age_sec is a runtime flag
......................................................................


Patch Set 1: Verified+1

unrelated test failure (ASAN): AutoAddMasterTest.TestRestartMastersWhileSomeDown


-- 
To view, visit http://gerrit.cloudera.org:8080/19286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2b1553325cd33953d104b5bb3e8aeb73d90642a
Gerrit-Change-Number: 19286
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 29 Nov 2022 23:49:56 +0000
Gerrit-HasComments: No

[kudu-CR] [tablet] --tablet history max age sec is a runtime flag

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19286 )

Change subject: [tablet] --tablet_history_max_age_sec is a runtime flag
......................................................................

[tablet] --tablet_history_max_age_sec is a runtime flag

The way how --tablet_history_max_age_sec is used in
Tablet::GetTabletAncientHistoryMark() mandates a 'runtime' tag for the
flag.  That allows for using the `kudu tserver set_flag` CLI tool
without adding the --force option when updating the setting.

Change-Id: Ie2b1553325cd33953d104b5bb3e8aeb73d90642a
Reviewed-on: http://gerrit.cloudera.org:8080/19286
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Yifan Zhang <ch...@163.com>
---
M src/kudu/tablet/tablet.cc
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Alexey Serbin: Verified
  Yifan Zhang: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/19286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2b1553325cd33953d104b5bb3e8aeb73d90642a
Gerrit-Change-Number: 19286
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] [tablet] --tablet history max age sec is a runtime flag

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [tablet] --tablet_history_max_age_sec is a runtime flag
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/19286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ie2b1553325cd33953d104b5bb3e8aeb73d90642a
Gerrit-Change-Number: 19286
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] [tablet] --tablet history max age sec is a runtime flag

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19286 )

Change subject: [tablet] --tablet_history_max_age_sec is a runtime flag
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2b1553325cd33953d104b5bb3e8aeb73d90642a
Gerrit-Change-Number: 19286
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 30 Nov 2022 14:27:12 +0000
Gerrit-HasComments: No