You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/04 00:53:15 UTC

[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #11272: [Feature][style] Add spotless maven plugin for automatic style fix.

kezhenxu94 commented on code in PR #11272:
URL: https://github.com/apache/dolphinscheduler/pull/11272#discussion_r937256650


##########
style/license-header:
##########
@@ -0,0 +1,17 @@
+/*

Review Comment:
   > I'm not sure whether `skywalking-eyes` could add the license header for users or not. `Spotless` could automatically add it if there is no license header.
   
   License eye can add license headers and it deals with all files. I think spotless only deals with the files within maven project's files?
    Anyway I don't think we should have two tools to do the same thing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org