You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2021/02/09 09:26:50 UTC

[GitHub] [buildstream] abderrahim commented on a change in pull request #1440: _context.py: make directories in the configuration absolute

abderrahim commented on a change in pull request #1440:
URL: https://github.com/apache/buildstream/pull/1440#discussion_r572721875



##########
File path: src/buildstream/_context.py
##########
@@ -282,6 +282,7 @@ def load(self, config=None):
             path = os.path.expanduser(path)
             path = os.path.expandvars(path)
             path = os.path.normpath(path)
+            path = os.path.abspath(path)

Review comment:
       Actually, this is a forward port of #1441. bst-1 accepts relative paths at this point, but fails in funny ways later on. If this is not supported in bst-2 (something I didn't test), we should probably backport that change instead.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org