You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by kr...@apache.org on 2012/09/19 18:52:36 UTC

git commit: [SUREFIRE-909] Wrong elapsed time calculation

Updated Branches:
  refs/heads/master [created] 8dbde6de8


[SUREFIRE-909] Wrong elapsed time calculation

Fixed with unit test


Project: http://git-wip-us.apache.org/repos/asf/maven-surefire/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven-surefire/commit/8dbde6de
Tree: http://git-wip-us.apache.org/repos/asf/maven-surefire/tree/8dbde6de
Diff: http://git-wip-us.apache.org/repos/asf/maven-surefire/diff/8dbde6de

Branch: refs/heads/master
Commit: 8dbde6de81cddd7335a5768dc22d9c414db6ef86
Parents: 32ed35b
Author: Kristian Rosenvold <kr...@gmail.com>
Authored: Tue Sep 18 20:34:15 2012 +0200
Committer: Kristian Rosenvold <kr...@gmail.com>
Committed: Tue Sep 18 20:35:37 2012 +0200

----------------------------------------------------------------------
 .../plugin/surefire/report/WrappedReportEntry.java |    2 +-
 .../surefire/report/WrappedReportEntryTest.java    |   10 ++++++++++
 2 files changed, 11 insertions(+), 1 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/maven-surefire/blob/8dbde6de/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/WrappedReportEntry.java
----------------------------------------------------------------------
diff --git a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/WrappedReportEntry.java b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/WrappedReportEntry.java
index cbf1da8..c93c1e1 100644
--- a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/WrappedReportEntry.java
+++ b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/WrappedReportEntry.java
@@ -147,7 +147,7 @@ public class WrappedReportEntry implements ReportEntry
         StringBuilder reportContent = new StringBuilder();
         reportContent.append( getName() );
         reportContent.append( "  Time elapsed: " );
-        reportContent.append( getElapsed() );
+        reportContent.append( elapsedTimeAsString() );
         reportContent.append( " sec" );
 
         return reportContent.toString();

http://git-wip-us.apache.org/repos/asf/maven-surefire/blob/8dbde6de/maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/WrappedReportEntryTest.java
----------------------------------------------------------------------
diff --git a/maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/WrappedReportEntryTest.java b/maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/WrappedReportEntryTest.java
index 4585937..1229546 100644
--- a/maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/WrappedReportEntryTest.java
+++ b/maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/WrappedReportEntryTest.java
@@ -57,5 +57,15 @@ public class WrappedReportEntryTest
         assertEquals( "[0] 1, 2, 3 (testSum)", reportName );
     }
 
+    public void testElapsed()
+        throws Exception
+    {
+        String category = "[0] 1\u002C 2\u002C 3 (testSum)(surefire.testcase.JunitParamsTest)";
+        ReportEntry reportEntry = new SimpleReportEntry( "fud", category );
+        WrappedReportEntry wr = new WrappedReportEntry( reportEntry, null, 12, null, null );
+        String elapsedTimeSummary = wr.getElapsedTimeSummary();
+        assertEquals( "[0] 1, 2, 3 (testSum)(surefire.testcase.JunitParamsTest)  Time elapsed: 0.012 sec", elapsedTimeSummary );
+    }
+
 
 }