You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2017/11/17 01:38:44 UTC

[GitHub] Antonio-Maranhao opened a new pull request #1025: Show a badge on a tab header

Antonio-Maranhao opened a new pull request #1025: Show a badge on a tab header
URL: https://github.com/apache/couchdb-fauxton/pull/1025
 
 
   ## Overview
   
   Add ability to show a badge on a tab header.
   
   ![image](https://user-images.githubusercontent.com/30349380/32925087-0f6ea9b6-cb0e-11e7-9e7b-fafa9773291a.png)
   
   
   ## Testing recommendations
   
   To see it in action you can replace the code in https://github.com/apache/couchdb-fauxton/blob/master/app/addons/activetasks/components.js#L119 with: 
   ```
   <TabElement
               key={i}
               selected={checked}
               text={radioName}
               onChange={this.onRadioClick}
               badgeText={ i == 1 ? '999' : ''} />
   ```
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   - [ ] Update [rebar.config.script](https://github.com/apache/couchdb/blob/master/rebar.config.script) with the correct tag once a new Fauxton release is made
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services