You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/08 07:03:17 UTC
[GitHub] [camel-quarkus] Jeansen opened a new pull request #1730: Promote AWS 2 Lambda to native
Jeansen opened a new pull request #1730:
URL: https://github.com/apache/camel-quarkus/pull/1730
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1730: Promote AWS 2 Lambda to native
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1730:
URL: https://github.com/apache/camel-quarkus/pull/1730#issuecomment-688732290
It is perfect from my PoV now, thanks @Jeansen !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] Jeansen commented on pull request #1730: Promote AWS 2 Lambda to native
Posted by GitBox <gi...@apache.org>.
Jeansen commented on pull request #1730:
URL: https://github.com/apache/camel-quarkus/pull/1730#issuecomment-688682683
> I don't think this javascript should be in the extension.
so, remove the whole lib folder with the .js files?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] Jeansen commented on pull request #1730: Promote AWS 2 Lambda to native
Posted by GitBox <gi...@apache.org>.
Jeansen commented on pull request #1730:
URL: https://github.com/apache/camel-quarkus/pull/1730#issuecomment-688684584
I see, the other extensions do not have it either, will remove the lib folder
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] Jeansen commented on a change in pull request #1730: Promote AWS 2 Lambda to native
Posted by GitBox <gi...@apache.org>.
Jeansen commented on a change in pull request #1730:
URL: https://github.com/apache/camel-quarkus/pull/1730#discussion_r484734720
##########
File path: integration-tests/dropbox/pom.xml
##########
@@ -65,6 +65,8 @@
<scope>test</scope>
</dependency>
+ <!-- The following dependencies guarantee that this module is built after them. You can update them by running `mvn process-resources -Pformat -N` from the source tree root directory -->
+
<!-- The following dependencies guarantee that this module is built after them. You can update them by runing `mvn process-resources -Pformat -N` from the source tree root directory -->
Review comment:
OK, I've removed the second line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] Jeansen commented on pull request #1730: Promote AWS 2 Lambda to native
Posted by GitBox <gi...@apache.org>.
Jeansen commented on pull request #1730:
URL: https://github.com/apache/camel-quarkus/pull/1730#issuecomment-688703029
> Thanks @Jeansen ! A minor comment inline. Besides, if you could please use more descriptive commit messages next time. Issue title would be nice in addition to the issue number.
@ppalaga I am sorry, I've added the issue title to my commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #1730: Promote AWS 2 Lambda to native
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #1730:
URL: https://github.com/apache/camel-quarkus/pull/1730
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1730: Promote AWS 2 Lambda to native
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1730:
URL: https://github.com/apache/camel-quarkus/pull/1730#discussion_r484724069
##########
File path: integration-tests/dropbox/pom.xml
##########
@@ -65,6 +65,8 @@
<scope>test</scope>
</dependency>
+ <!-- The following dependencies guarantee that this module is built after them. You can update them by running `mvn process-resources -Pformat -N` from the source tree root directory -->
+
<!-- The following dependencies guarantee that this module is built after them. You can update them by runing `mvn process-resources -Pformat -N` from the source tree root directory -->
Review comment:
```suggestion
```
The first comment has the correct spelling. Could you please remove the second one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org