You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by ConcurrencyPractitioner <gi...@git.apache.org> on 2017/09/13 03:22:29 UTC
[GitHub] kafka pull request #3842: [Kafka-5301] Improve exception handling on consume...
GitHub user ConcurrencyPractitioner opened a pull request:
https://github.com/apache/kafka/pull/3842
[Kafka-5301] Improve exception handling on consumer path
This is an improvised approach towards fixing @guozhangwang 's second issue.
I have changed the method return type as well as override such that it returns exception.
If the exception returned is not null (the default value), than we skip the callback.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ConcurrencyPractitioner/kafka trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3842.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3842
----
commit 6290df2070f215d0b355f3e59717d911e50b8973
Author: Richard Yu <ri...@richards-air.attlocal.net>
Date: 2017-09-13T03:19:24Z
[Kafka-5301] Improve exception handling on consumer path
----
---
[GitHub] kafka pull request #3842: KAFKA-5301 Improve exception handling on consumer ...
Posted by ConcurrencyPractitioner <gi...@git.apache.org>.
Github user ConcurrencyPractitioner closed the pull request at:
https://github.com/apache/kafka/pull/3842
---
[GitHub] kafka pull request #3842: KAFKA-5301 Improve exception handling on consumer ...
Posted by ConcurrencyPractitioner <gi...@git.apache.org>.
Github user ConcurrencyPractitioner closed the pull request at:
https://github.com/apache/kafka/pull/3842
---
[GitHub] kafka pull request #3842: KAFKA-5301 Improve exception handling on consumer ...
Posted by ConcurrencyPractitioner <gi...@git.apache.org>.
GitHub user ConcurrencyPractitioner reopened a pull request:
https://github.com/apache/kafka/pull/3842
KAFKA-5301 Improve exception handling on consumer path
This is an improvised approach towards fixing @guozhangwang 's second issue.
I have changed the method return type as well as override such that it returns exception.
If the exception returned is not null (the default value), than we skip the callback.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ConcurrencyPractitioner/kafka trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3842.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3842
----
commit 6290df2070f215d0b355f3e59717d911e50b8973
Author: Richard Yu <ri...@richards-air.attlocal.net>
Date: 2017-09-13T03:19:24Z
[Kafka-5301] Improve exception handling on consumer path
commit 3a01de2d4e293d15da5c390bc5179243bbdb833e
Author: Richard Yu <ri...@richards-air.attlocal.net>
Date: 2017-09-13T22:34:11Z
Exception handling add-on
----
---