You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/05 15:32:46 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #8580:
[FLINK-12683] Provide task manager location information for checkpoint
coordinator specific log messages
tillrohrmann commented on a change in pull request #8580: [FLINK-12683] Provide task manager location information for checkpoint coordinator specific log messages
URL: https://github.com/apache/flink/pull/8580#discussion_r290793656
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorFailureTest.java
##########
@@ -112,7 +113,7 @@ public void testFailingCompletedCheckpointStoreAdd() throws Exception {
AcknowledgeCheckpoint acknowledgeMessage = new AcknowledgeCheckpoint(jid, executionAttemptId, checkpointId, new CheckpointMetrics(), subtaskState);
try {
- coord.receiveAcknowledgeMessage(acknowledgeMessage);
+ coord.receiveAcknowledgeMessage(acknowledgeMessage, mock(TaskManagerLocation.class));
Review comment:
Instead of mocking please use `LocalTaskManagerLocation`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services