You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/16 12:47:57 UTC
[GitHub] [airflow] potiuk opened a new pull request #8403: Test script tries
to reset db regardless of db check
potiuk opened a new pull request #8403: Test script tries to reset db regardless of db check
URL: https://github.com/apache/airflow/pull/8403
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #8403: Test
script tries to reset db regardless of db check
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #8403: Test script tries to reset db regardless of db check
URL: https://github.com/apache/airflow/pull/8403#discussion_r409587213
##########
File path: scripts/ci/in_container/check_environment.sh
##########
@@ -217,15 +220,21 @@ check_integration rabbitmq "nc -zvv rabbitmq 5672" 20
check_integration cassandra "nc -zvv cassandra 9042" 20
check_integration openldap "nc -zvv openldap 389" 20
-resetdb
-
if [[ ${EXIT_CODE} != 0 ]]; then
echo
echo "Error: some of the CI environment failed to initialize!"
echo
exit ${EXIT_CODE}
fi
+# Try to reset the database regardless of DB_EXIT_CODE. If this fails, the whole script will fail
+resetdb
Review comment:
Yep. we we are in -e mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #8403: Test
script tries to reset db regardless of db check
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #8403: Test script tries to reset db regardless of db check
URL: https://github.com/apache/airflow/pull/8403#discussion_r409530829
##########
File path: scripts/ci/in_container/check_environment.sh
##########
@@ -217,15 +220,21 @@ check_integration rabbitmq "nc -zvv rabbitmq 5672" 20
check_integration cassandra "nc -zvv cassandra 9042" 20
check_integration openldap "nc -zvv openldap 389" 20
-resetdb
-
if [[ ${EXIT_CODE} != 0 ]]; then
echo
echo "Error: some of the CI environment failed to initialize!"
echo
exit ${EXIT_CODE}
fi
+# Try to reset the database regardless of DB_EXIT_CODE. If this fails, the whole script will fail
+resetdb
Review comment:
Are we in `set -e` mode here, or would we not actually know if this failed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #8403: Test script tries to
reset db regardless of db check
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #8403: Test script tries to reset db regardless of db check
URL: https://github.com/apache/airflow/pull/8403#issuecomment-614667965
Also Green and review needed :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #8403: Test script tries to
reset db regardless of db check
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #8403: Test script tries to reset db regardless of db check
URL: https://github.com/apache/airflow/pull/8403
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services