You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/14 16:03:41 UTC

[GitHub] [airflow] potiuk commented on pull request #17609: sftp_to_s3 stream file option

potiuk commented on pull request #17609:
URL: https://github.com/apache/airflow/pull/17609#issuecomment-898912306


   Two things:
   1) Static checks are failing (i heartily recommend installing [pre-commit](https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) to catch those kind of checks at commit time (saves a lot on iterating with the change) 
   
   2) Unit tests should be added. We are very keen on getting all the new functionality covered by unit tests - any change that adds some functionality should have accompanying unit-tests to avoid regressions.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org