You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/07/24 00:13:38 UTC
[GitHub] [hadoop-ozone] bharatviswa504 opened a new pull request #1252: HDDS-4010. S3G startup fails when multiple service ids are configured.
bharatviswa504 opened a new pull request #1252:
URL: https://github.com/apache/hadoop-ozone/pull/1252
## What changes were proposed in this pull request?
This Jira is to fix this TODO.
**OzoneServiceProvider.java L59:
// HA cluster.
//For now if multiple service id's are configured we throw exception.
// As if multiple service id's are configured, S3Gateway will not be
// knowing which one to talk to. In future, if OM federation is supported
// we can resolve this by having another property like
// ozone.om.internal.service.id.
// TODO: Revisit this later.
if (serviceIdList.size() > 1) {
throw new IllegalArgumentException("Multiple serviceIds are " +
"configured. " + Arrays.toString(serviceIdList.toArray()));**
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4010
## How was this patch tested?
HDDS-4008 added test for configuration, this Jira reuses the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1252: HDDS-4010. S3G startup fails when multiple service ids are configured.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #1252:
URL: https://github.com/apache/hadoop-ozone/pull/1252#discussion_r461838645
##########
File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneServiceProvider.java
##########
@@ -49,34 +49,24 @@
@PostConstruct
public void init() {
- Collection<String> serviceIdList =
- conf.getTrimmedStringCollection(OZONE_OM_SERVICE_IDS_KEY);
- if (serviceIdList.size() == 0) {
- // Non-HA cluster
+ try {
+ omserviceID = OmUtils.getOzoneManagerServiceId(conf);
+ } catch (IOException ex) {
+ throw new ConfigurationException(ex.getMessage(), ex);
Review comment:
When it has more than one service id, it will fail only when internal service id is not configured.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1252: HDDS-4010. S3G startup fails when multiple service ids are configured.
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1252:
URL: https://github.com/apache/hadoop-ozone/pull/1252#issuecomment-670391639
/pending on continue the discussion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] github-actions[bot] commented on pull request #1252: HDDS-4010. S3G startup fails when multiple service ids are configured.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1252:
URL: https://github.com/apache/hadoop-ozone/pull/1252#issuecomment-683199498
Thank you very much for the patch. I am closing this PR __temporarily__ as there was no activity recently and it is waiting for response from its author.
It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.
It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.
If you need ANY help to finish this PR, please [contact the community](https://github.com/apache/hadoop-ozone#contact) on the mailing list or the slack channel."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] github-actions[bot] closed pull request #1252: HDDS-4010. S3G startup fails when multiple service ids are configured.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1252:
URL: https://github.com/apache/hadoop-ozone/pull/1252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1252: HDDS-4010. S3G startup fails when multiple service ids are configured.
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1252:
URL: https://github.com/apache/hadoop-ozone/pull/1252#issuecomment-664821183
It seems to be related to #1149
See my related comments:
https://github.com/apache/hadoop-ozone/pull/1149#issuecomment-664814018
https://github.com/apache/hadoop-ozone/pull/1149#issuecomment-664815366
Today, when only one serviceId is defined, it is used by s3g. This is th exact behavior which is suggested by #1149 for ozon shell commands.
Why I like the ne aproach to make the default serviceId configurable in case of multiple serviceId present, I would make it optional if one (and only one) serviceId is defined.
I would consider to keep the current behavior in this specific use case. Do you see any risk to keep it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org