You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by franz1981 <gi...@git.apache.org> on 2018/03/21 17:08:45 UTC
[GitHub] activemq-artemis pull request #1963: ARTEMIS-1757 Improve DB2 compatibility
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1963
ARTEMIS-1757 Improve DB2 compatibility
It includes:
- Fixed AUTO_INCREMENT not supported on DB2
- Added proper stop/teardown of driver
- Fixed recursive SQLException formatting
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/franz1981/activemq-artemis DB_2_JDBC_TESTS
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1963.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1963
----
commit f5868a94e1a1534ddb8a44c854c132e8b20f1b9d
Author: Francesco Nigro <ni...@...>
Date: 2018-02-16T14:45:45Z
ARTEMIS-1757 Improve DB2 compatibility
It includes:
- Fixed AUTO_INCREMENT not supported on DB2
- Added proper stop/teardown of driver
- Fixed recursive SQLException formatting
----
---
[GitHub] activemq-artemis pull request #1963: ARTEMIS-1757 Improve DB2 compatibility
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1963#discussion_r177431410
--- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java ---
@@ -95,6 +95,7 @@ public void stop() throws SQLException {
synchronized (connection) {
if (sqlProvider.closeConnectionOnShutdown()) {
try {
+ connection.setAutoCommit(true);
--- End diff --
this is dangerous.. isn't?
why did you need it?
---
[GitHub] activemq-artemis pull request #1963: ARTEMIS-1757 Improve DB2 compatibility
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1963
---
[GitHub] activemq-artemis issue #1963: ARTEMIS-1757 Improve DB2 compatibility
Posted by franz1981 <gi...@git.apache.org>.
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1963
The tests has worked and it could be merged safely. If new compatibility issues will arise I will push a new PR with the additional fixes :)
---
[GitHub] activemq-artemis issue #1963: ARTEMIS-1757 Improve DB2 compatibility
Posted by franz1981 <gi...@git.apache.org>.
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1963
DO NOT MERGE YET, I'm running some tests to see if there are other evident compatibility issues (SQL syntax and weird exception/driver behaviours).
---