[GitHub] [cassandra] maedhroz commented on a change in pull request #844: CASSANDRA-16331 Extend the exclusion of replica filtering protection to other indices instead of just SASI

[GitBox <gi...@apache.org>]

maedhroz commented on a change in pull request #844:
URL: https://github.com/apache/cassandra/pull/844#discussion_r538635567



##########
File path: src/java/org/apache/cassandra/index/Index.java
##########
@@ -426,6 +426,16 @@ public Indexer indexerFor(DecoratedKey key,
                               WriteContext ctx,
                               IndexTransaction.Type transactionType);
 
+    /**
+     * Tells whether this index supports replica fitering protection or not.
+     *
+     * @return true if this index supports replica filtering protection, false otherwise
+     */
+    default boolean supportsReplicaFilteringProtection()

Review comment:
       I would like Zhao's proposal if this was around an optional feature, but in some ways RFP is *required*, given an index implementation can't be correct without supporting it. (i.e. In a perfect world we wouldn't need the method at all.) In terms of naming, I'm fine with `supportsFiltering()` as long as the JavaDoc outlines RFP as an example of why we would need to filter.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org