You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Padma Priya N <pa...@gmail.com> on 2017/02/21 06:04:03 UTC
Review Request 56863: AMBARI-20084.Cut Node feature is broken in
workflow manager
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56863/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Bugs: AMBARI-20084
https://issues.apache.org/jira/browse/AMBARI-20084
Repository: ambari
Description
-------
The incoming transition list of the node to be cut was passed as an argument to deleteNode. Fixed by passing the list of incoming tranistions to delete node.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js c1bd4be
contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js 6f46fdc
Diff: https://reviews.apache.org/r/56863/diff/
Testing
-------
Manual Testing
Thanks,
Padma Priya N
Re: Review Request 56863: AMBARI-20084.Cut Node feature is broken in
workflow manager
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56863/#review166137
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 21, 2017, 6:04 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56863/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 6:04 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20084
> https://issues.apache.org/jira/browse/AMBARI-20084
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The incoming transition list of the node to be cut was passed as an argument to deleteNode. Fixed by passing the list of incoming tranistions to delete node.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js c1bd4be
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js 6f46fdc
>
> Diff: https://reviews.apache.org/r/56863/diff/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>
Re: Review Request 56863: AMBARI-20084.Cut Node feature is broken in
workflow manager
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56863/#review166129
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On Feb. 21, 2017, 6:04 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56863/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 6:04 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20084
> https://issues.apache.org/jira/browse/AMBARI-20084
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The incoming transition list of the node to be cut was passed as an argument to deleteNode. Fixed by passing the list of incoming tranistions to delete node.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js c1bd4be
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js 6f46fdc
>
> Diff: https://reviews.apache.org/r/56863/diff/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>