You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2016/11/03 19:41:59 UTC
[jira] [Commented] (HBASE-17015) Multipile identical CacheConfig
log messages in a log file and refactoring around CacheConfig inheritance
[ https://issues.apache.org/jira/browse/HBASE-17015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634000#comment-15634000 ]
stack commented on HBASE-17015:
-------------------------------
We CacheConfig whenever we open a Region (twice). We do it (once?) when we compact. See below. Yeah, mob is using cache config but it looks like it shouldn't be using it. Thanks [~uagashe]
307816 2016-10-13 12:24:45,306 INFO [regionserver/ve0528.halxg.cloudera.com/10.17.240.22:16020-longCompactions-1476317858127] hfile.CacheConfig: blockCache=LruBlockCache{blockCount=12, currentSize=23198408, freeSize=22529416504, maxSize =22552614912, heapSize=23198408, minSize=21424984064, minFactor=0.95, multiSize=10712492032, multiFactor=0.5, singleSize=5356246016, singleFactor=0.25}, cacheDataOnRead=true, cacheDataOnWrite=false, cacheIndexesOnWrite=false, cach eBloomsOnWrite=false, cacheEvictOnClose=false, cacheDataCompressed=false, prefetchOnOpen=false
307817 2016-10-13 12:24:45,306 INFO [regionserver/ve0528.halxg.cloudera.com/10.17.240.22:16020-shortCompactions-1476386685271] hfile.CacheConfig: blockCache=LruBlockCache{blockCount=12, currentSize=23198408, freeSize=22529416504, maxSiz e=22552614912, heapSize=23198408, minSize=21424984064, minFactor=0.95, multiSize=10712492032, multiFactor=0.5, singleSize=5356246016, singleFactor=0.25}, cacheDataOnRead=true, cacheDataOnWrite=false, cacheIndexesOnWrite=false, cac heBloomsOnWrite=false, cacheEvictOnClose=false, cacheDataCompressed=false, prefetchOnOpen=false
307818 2016-10-13 12:24:45,323 INFO [regionserver/ve0528.halxg.cloudera.com/10.17.240.22:16020-longCompactions-1476317858127] throttle.PressureAwareThroughputController: hbase:meta,,1.1588230740#table#compaction#5 average throughput is unlimited, slept 0 time(s) and total slept time is 0 ms. 1 active operations remaining, total limit is 10.00 MB/sec
> Multipile identical CacheConfig log messages in a log file and refactoring around CacheConfig inheritance
> ---------------------------------------------------------------------------------------------------------
>
> Key: HBASE-17015
> URL: https://issues.apache.org/jira/browse/HBASE-17015
> Project: HBase
> Issue Type: Improvement
> Reporter: Umesh Agashe
> Assignee: Umesh Agashe
>
> There are two issues here:
> 1. CacheConfig is logged multiple times (some times on adjacent lines) in log file. The reason for this is: {code} LOG.info(this) {code} in CacheConfig constructor. So when CacheConfig and any derived class is instantiated message appears multiple times in a log. The message itself doesn't have any context and look identical. Logging CacheConfig from outside constructor will fix this issue.
> 2. During debugging its noticed that CacheConfig is meant for in memory block cache but is used for different caches (in some cases for non in memory block caches). This can be improved by refactoring the inheritance of CacheConfig.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)