You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Yongqiang He <he...@gmail.com> on 2011/04/07 19:43:21 UTC
Review Request: auto map join bug
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/559/
-----------------------------------------------------------
Review request for hive.
Summary
-------
auto map join bug
Diffs
-----
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java 1088810
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 1088810
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinResolver.java 1088810
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LocalMapJoinProcFactory.java 1088810
trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverCommonJoin.java 1088810
trunk/ql/src/test/queries/clientpositive/auto_join28.q PRE-CREATION
trunk/ql/src/test/queries/clientpositive/auto_join29.q PRE-CREATION
trunk/ql/src/test/queries/clientpositive/auto_join30.q PRE-CREATION
trunk/ql/src/test/results/clientpositive/auto_join12.q.out 1088810
trunk/ql/src/test/results/clientpositive/auto_join20.q.out 1088810
trunk/ql/src/test/results/clientpositive/auto_join21.q.out 1088810
trunk/ql/src/test/results/clientpositive/auto_join28.q.out PRE-CREATION
trunk/ql/src/test/results/clientpositive/auto_join29.q.out PRE-CREATION
trunk/ql/src/test/results/clientpositive/auto_join3.q.out 1088810
trunk/ql/src/test/results/clientpositive/auto_join30.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/559/diff
Testing
-------
yes.
Thanks,
Yongqiang
Re: Review Request: auto map join bug
Posted by namit jain <nj...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/559/#review401
-----------------------------------------------------------
also add a test for
A Rigth Outer Join B on ..
Join C
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java
<https://reviews.apache.org/r/559/#comment774>
minor bug in case of
A Right Outer join B on...
Join C
Both B and C can be big tables
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinResolver.java
<https://reviews.apache.org/r/559/#comment775>
spelling of the variable
- namit
On 2011-04-07 17:43:21, Yongqiang He wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/559/
> -----------------------------------------------------------
>
> (Updated 2011-04-07 17:43:21)
>
>
> Review request for hive.
>
>
> Summary
> -------
>
> auto map join bug
>
>
> Diffs
> -----
>
> trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java 1088810
> trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 1088810
> trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinResolver.java 1088810
> trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LocalMapJoinProcFactory.java 1088810
> trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverCommonJoin.java 1088810
> trunk/ql/src/test/queries/clientpositive/auto_join28.q PRE-CREATION
> trunk/ql/src/test/queries/clientpositive/auto_join29.q PRE-CREATION
> trunk/ql/src/test/queries/clientpositive/auto_join30.q PRE-CREATION
> trunk/ql/src/test/results/clientpositive/auto_join12.q.out 1088810
> trunk/ql/src/test/results/clientpositive/auto_join20.q.out 1088810
> trunk/ql/src/test/results/clientpositive/auto_join21.q.out 1088810
> trunk/ql/src/test/results/clientpositive/auto_join28.q.out PRE-CREATION
> trunk/ql/src/test/results/clientpositive/auto_join29.q.out PRE-CREATION
> trunk/ql/src/test/results/clientpositive/auto_join3.q.out 1088810
> trunk/ql/src/test/results/clientpositive/auto_join30.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/559/diff
>
>
> Testing
> -------
>
> yes.
>
>
> Thanks,
>
> Yongqiang
>
>