You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/14 07:05:22 UTC
[GitHub] [kafka] tang7526 opened a new pull request #11047: MINOR: Remove unnecessary code for WindowStoreBuilder.
tang7526 opened a new pull request #11047:
URL: https://github.com/apache/kafka/pull/11047
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tang7526 commented on a change in pull request #11047: MINOR: Remove unnecessary code for WindowStoreBuilder.
Posted by GitBox <gi...@apache.org>.
tang7526 commented on a change in pull request #11047:
URL: https://github.com/apache/kafka/pull/11047#discussion_r726044536
##########
File path: streams/src/main/java/org/apache/kafka/streams/state/internals/WindowStoreBuilder.java
##########
@@ -36,7 +36,6 @@ public WindowStoreBuilder(final WindowBytesStoreSupplier storeSupplier,
final Serde<V> valueSerde,
final Time time) {
super(storeSupplier.name(), keySerde, valueSerde, time);
- Objects.requireNonNull(storeSupplier, "storeSupplier can't be null");
Review comment:
@abbccdda It's already done, thanks your comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tang7526 commented on a change in pull request #11047: MINOR: Remove unnecessary code for WindowStoreBuilder.
Posted by GitBox <gi...@apache.org>.
tang7526 commented on a change in pull request #11047:
URL: https://github.com/apache/kafka/pull/11047#discussion_r671973575
##########
File path: streams/src/main/java/org/apache/kafka/streams/state/internals/WindowStoreBuilder.java
##########
@@ -36,7 +36,6 @@ public WindowStoreBuilder(final WindowBytesStoreSupplier storeSupplier,
final Serde<V> valueSerde,
final Time time) {
super(storeSupplier.name(), keySerde, valueSerde, time);
- Objects.requireNonNull(storeSupplier, "storeSupplier can't be null");
Review comment:
@abbccdda It will throw an exception at line 38 if `storeSupplier ` is null. So line 39 is redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda commented on a change in pull request #11047: MINOR: Remove unnecessary code for WindowStoreBuilder.
Posted by GitBox <gi...@apache.org>.
abbccdda commented on a change in pull request #11047:
URL: https://github.com/apache/kafka/pull/11047#discussion_r695050765
##########
File path: streams/src/main/java/org/apache/kafka/streams/state/internals/WindowStoreBuilder.java
##########
@@ -36,7 +36,6 @@ public WindowStoreBuilder(final WindowBytesStoreSupplier storeSupplier,
final Serde<V> valueSerde,
final Time time) {
super(storeSupplier.name(), keySerde, valueSerde, time);
- Objects.requireNonNull(storeSupplier, "storeSupplier can't be null");
Review comment:
@tang7526 Thanks, could we do sth similar to https://github.com/apache/kafka/blob/d30b4e51513e6938970020bf1e894c983447ef8f/streams/src/main/java/org/apache/kafka/streams/state/internals/SessionStoreBuilder.java#L36 here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda commented on a change in pull request #11047: MINOR: Remove unnecessary code for WindowStoreBuilder.
Posted by GitBox <gi...@apache.org>.
abbccdda commented on a change in pull request #11047:
URL: https://github.com/apache/kafka/pull/11047#discussion_r671888919
##########
File path: streams/src/main/java/org/apache/kafka/streams/state/internals/WindowStoreBuilder.java
##########
@@ -36,7 +36,6 @@ public WindowStoreBuilder(final WindowBytesStoreSupplier storeSupplier,
final Serde<V> valueSerde,
final Time time) {
super(storeSupplier.name(), keySerde, valueSerde, time);
- Objects.requireNonNull(storeSupplier, "storeSupplier can't be null");
Review comment:
Could you elaborate why this is not required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tang7526 commented on a change in pull request #11047: MINOR: Remove unnecessary code for WindowStoreBuilder.
Posted by GitBox <gi...@apache.org>.
tang7526 commented on a change in pull request #11047:
URL: https://github.com/apache/kafka/pull/11047#discussion_r671973575
##########
File path: streams/src/main/java/org/apache/kafka/streams/state/internals/WindowStoreBuilder.java
##########
@@ -36,7 +36,6 @@ public WindowStoreBuilder(final WindowBytesStoreSupplier storeSupplier,
final Serde<V> valueSerde,
final Time time) {
super(storeSupplier.name(), keySerde, valueSerde, time);
- Objects.requireNonNull(storeSupplier, "storeSupplier can't be null");
Review comment:
@abbccdda It will throw a exception at line 38 if `storeSupplier ` is null. So line 39 is redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org