[GitHub] [arrow-rs] Jimexist commented on a diff in pull request #3119: parquet bloom filter part III: add sbbf writer, remove `bloom` feature, add reader properties

[GitBox <gi...@apache.org>]

Jimexist commented on code in PR #3119:
URL: https://github.com/apache/arrow-rs/pull/3119#discussion_r1024625516


##########
parquet/Cargo.toml:
##########
@@ -57,7 +57,8 @@ seq-macro = { version = "0.3", default-features = false }
 futures = { version = "0.3", default-features = false, features = ["std"], optional = true }
 tokio = { version = "1.0", optional = true, default-features = false, features = ["macros", "rt", "io-util"] }
 hashbrown = { version = "0.13", default-features = false }
-twox-hash = { version = "1.6", optional = true }
+twox-hash = { version = "1.6", default-features = false }

Review Comment:
   it by default relies on `rand` which breaks `wasm32`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org