You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/09/21 01:28:52 UTC
[kudu-CR] thirdparty: fix to protobuf bump
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8115
to review the following change.
Change subject: thirdparty: fix to protobuf bump
......................................................................
thirdparty: fix to protobuf bump
Commit 57de48d bumped protobuf to 3.4.1 but forgot to remove this line,
which meant that every time download-thirdparty.sh was called, it'd
redownload and extract the protobuf tarball.
Change-Id: I3d1d05b60051a355a177dd2807ac56debaf1b7a0
---
M thirdparty/download-thirdparty.sh
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/8115/1
--
To view, visit http://gerrit.cloudera.org:8080/8115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d1d05b60051a355a177dd2807ac56debaf1b7a0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] thirdparty: fix to protobuf bump
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8115 )
Change subject: thirdparty: fix to protobuf bump
......................................................................
thirdparty: fix to protobuf bump
Commit 57de48d bumped protobuf to 3.4.1 but didn't remove the call to
delete_if_wrong_patchlevel, which meant that every time
download-thirdparty.sh was run, it'd redownload and reextract protobuf.
Rather than remove delete_if_wrong_patchlevel, this patch sets protobuf to
use patchlevel 0. That way, download-thirdparty.sh will rebuild protobuf
when switching between different git branches with differing protobuf
patchlevels. If we had removed the patchlevel altogether, it wouldn't be
smart enough to recognize a change and rebuild when switching back to "now".
Change-Id: I3d1d05b60051a355a177dd2807ac56debaf1b7a0
Reviewed-on: http://gerrit.cloudera.org:8080/8115
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
---
M thirdparty/download-thirdparty.sh
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
David Ribeiro Alves: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d1d05b60051a355a177dd2807ac56debaf1b7a0
Gerrit-Change-Number: 8115
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] thirdparty: fix to protobuf bump
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8115 )
Change subject: thirdparty: fix to protobuf bump
......................................................................
Patch Set 1:
> Patch Set 1:
>
> |I removed the patch level stuff in the recent Protobuf 3.3 -> 3.4 bump, since we aren't carrying any pb patches, and we don't kneed the patch level to differentiate a change in build flags. Are we gravitating towards always specifying a patch level now?
>
> Seemed like it from the comments on that patch and by the way that thirparty lib was added, which was why I asked.
Yea, I am +1 on always adding a patchlevel even if it's 0. This allows us to go to 1 and still trigger a rebuild when building past branches that are at level 0
--
To view, visit http://gerrit.cloudera.org:8080/8115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d1d05b60051a355a177dd2807ac56debaf1b7a0
Gerrit-Change-Number: 8115
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 21 Sep 2017 23:40:17 +0000
Gerrit-HasComments: No
[kudu-CR] thirdparty: fix to protobuf bump
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8115 )
Change subject: thirdparty: fix to protobuf bump
......................................................................
Patch Set 1:
I removed the patch level stuff in the recent Protobuf 3.3 -> 3.4 bump, since we aren't carrying any pb patches, and we don't kneed the patch level to differentiate a change in build flags. Are we gravitating towards always specifying a patch level now?
--
To view, visit http://gerrit.cloudera.org:8080/8115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d1d05b60051a355a177dd2807ac56debaf1b7a0
Gerrit-Change-Number: 8115
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 21 Sep 2017 18:03:58 +0000
Gerrit-HasComments: No
[kudu-CR] thirdparty: fix to protobuf bump
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8115 )
Change subject: thirdparty: fix to protobuf bump
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d1d05b60051a355a177dd2807ac56debaf1b7a0
Gerrit-Change-Number: 8115
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 22 Sep 2017 20:53:04 +0000
Gerrit-HasComments: No
[kudu-CR] thirdparty: fix to protobuf bump
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8115 )
Change subject: thirdparty: fix to protobuf bump
......................................................................
Patch Set 1:
Weren't we going to start using patch level 0 like in https://gerrit.cloudera.org/#/c/8007/ ?
--
To view, visit http://gerrit.cloudera.org:8080/8115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d1d05b60051a355a177dd2807ac56debaf1b7a0
Gerrit-Change-Number: 8115
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 21 Sep 2017 15:42:17 +0000
Gerrit-HasComments: No
[kudu-CR] thirdparty: fix to protobuf bump
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: thirdparty: fix to protobuf bump
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d1d05b60051a355a177dd2807ac56debaf1b7a0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] thirdparty: fix to protobuf bump
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8115
to look at the new patch set (#2).
Change subject: thirdparty: fix to protobuf bump
......................................................................
thirdparty: fix to protobuf bump
Commit 57de48d bumped protobuf to 3.4.1 but didn't remove the call to
delete_if_wrong_patchlevel, which meant that every time
download-thirdparty.sh was run, it'd redownload and reextract protobuf.
Rather than remove delete_if_wrong_patchlevel, this patch sets protobuf to
use patchlevel 0. That way, download-thirdparty.sh will rebuild protobuf
when switching between different git branches with differing protobuf
patchlevels. If we had removed the patchlevel altogether, it wouldn't be
smart enough to recognize a change and rebuild when switching back to "now".
Change-Id: I3d1d05b60051a355a177dd2807ac56debaf1b7a0
---
M thirdparty/download-thirdparty.sh
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/8115/2
--
To view, visit http://gerrit.cloudera.org:8080/8115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3d1d05b60051a355a177dd2807ac56debaf1b7a0
Gerrit-Change-Number: 8115
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] thirdparty: fix to protobuf bump
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8115 )
Change subject: thirdparty: fix to protobuf bump
......................................................................
Patch Set 2:
> Patch Set 1:
>
> > Patch Set 1:
> >
> > |I removed the patch level stuff in the recent Protobuf 3.3 -> 3.4 bump, since we aren't carrying any pb patches, and we don't kneed the patch level to differentiate a change in build flags. Are we gravitating towards always specifying a patch level now?
> >
> > Seemed like it from the comments on that patch and by the way that thirparty lib was added, which was why I asked.
>
> Yea, I am +1 on always adding a patchlevel even if it's 0. This allows us to go to 1 and still trigger a rebuild when building past branches that are at level 0
OK, patchlevel 0 is back.
--
To view, visit http://gerrit.cloudera.org:8080/8115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d1d05b60051a355a177dd2807ac56debaf1b7a0
Gerrit-Change-Number: 8115
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 22 Sep 2017 20:30:43 +0000
Gerrit-HasComments: No
[kudu-CR] thirdparty: fix to protobuf bump
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8115 )
Change subject: thirdparty: fix to protobuf bump
......................................................................
Patch Set 1:
Adar do you want to bring it back, or want me to?
--
To view, visit http://gerrit.cloudera.org:8080/8115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d1d05b60051a355a177dd2807ac56debaf1b7a0
Gerrit-Change-Number: 8115
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 21 Sep 2017 23:43:32 +0000
Gerrit-HasComments: No
[kudu-CR] thirdparty: fix to protobuf bump
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8115 )
Change subject: thirdparty: fix to protobuf bump
......................................................................
Patch Set 1:
|I removed the patch level stuff in the recent Protobuf 3.3 -> 3.4 bump, since we aren't carrying any pb patches, and we don't kneed the patch level to differentiate a change in build flags. Are we gravitating towards always specifying a patch level now?
Seemed like it from the comments on that patch and by the way that thirparty lib was added, which was why I asked.
--
To view, visit http://gerrit.cloudera.org:8080/8115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d1d05b60051a355a177dd2807ac56debaf1b7a0
Gerrit-Change-Number: 8115
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 21 Sep 2017 18:47:08 +0000
Gerrit-HasComments: No