[jira] [Commented] (LANG-687) Convert more of the StringUtils API to take CharSequence

["Henri Yandell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LANG-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016261#comment-13016261 ] 

Henri Yandell commented on LANG-687:
------------------------------------

Reopening - some of this will be done per the rule in the comment below.

By 'older', I mean 'previous'. i.e. the code added before the rollback.

svn ci -m "Replacing some of the older code. When performing a mutation operation (even if it's on an immutable by returning a new instance), String should go in and String should come out. When performing a non-mutation operation, CharSequence should be passed in. LANG-687"
Sending        src/main/java/org/apache/commons/lang3/StringUtils.java
Sending        src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java
Transmitting file data ..
Committed revision 1089302.


> Convert more of the StringUtils API to take CharSequence
> --------------------------------------------------------
>
>                 Key: LANG-687
>                 URL: https://issues.apache.org/jira/browse/LANG-687
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>            Reporter: Henri Yandell
>             Fix For: 3.0
>
>
> Wherever possible, use CharSequence and not String in the StringUtils API.
> Here is the working list of unique method names that don't take CharSequence. Let's update the description in place to show status.
> [DONE] abbreviate
> [DONE] abbreviateMiddle
> [DONE] center
> chomp
> chop
> [DONE] contains
> [DONE] containsAny
> containsIgnoreCase
> [DONE] containsWhitespace
> countMatches
> defaultString
> deleteWhitespace
> difference
> endsWith
> endsWithAny
> endsWithIgnoreCase
> equalsIgnoreCase
> getCommonPrefix
> [DONE] indexOf
> [DONE] indexOfAny
> [DONE] indexOfAnyBut
> indexOfIgnoreCase
> join
> [DONE] lastIndexOf
> [DONE] lastIndexOfAny
> lastIndexOfIgnoreCase
> lastOrdinalIndexOf
> [DONE] left
> [DONE] leftPad
> [DONE] lowerCase
> [DONE] mid
> normalizeSpace
> ordinalIndexOf
> overlay
> remove
> removeEnd
> removeEndIgnoreCase
> removeStart
> removeStartIgnoreCase
> repeat
> replace
> replaceChars
> replaceEach
> replaceEachRepeatedly
> replaceOnce
> reverse
> reverseDelimited
> [DONE] right
> [DONE] rightPad
> split
> splitByCharacterType
> splitByCharacterTypeCamelCase
> splitByWholeSeparator
> splitByWholeSeparatorPreserveAllTokens
> splitPreserveAllTokens
> startsWith
> startsWithAny
> startsWithIgnoreCase
> strip
> stripAll
> stripEnd
> stripStart
> stripToEmpty
> stripToNull
> [DONE] substring
> substringAfter
> substringAfterLast
> substringBefore
> substringBeforeLast
> substringBetween
> substringsBetween
> [DONE] swapCase
> trim
> trimToEmpty
> trimToNull
> [DONE] upperCase

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira