You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/02/04 05:17:05 UTC

[GitHub] [calcite] jaystarshot commented on a change in pull request #2710: [CALCITE-4997] Keep approx_count_distinct in RelToSql

jaystarshot commented on a change in pull request #2710:
URL: https://github.com/apache/calcite/pull/2710#discussion_r799167054



##########
File path: core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java
##########
@@ -1179,7 +1179,9 @@ private SqlCall toSql(SqlOperator op, boolean distinct,
 
       // Handle filter by generating FILTER (WHERE ...)
       final SqlCall call2;
-      if (filterArg < 0) {

Review comment:
       Why cannot we just check if `op instanceof SqlOperatorTable.APPROX_COUNT_DISTINCT`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org