[GitHub] gatorsmile commented on a change in pull request #18576: [SPARK-21351][SQL] Update nullability based on children's output

[GitBox <gi...@apache.org>]

gatorsmile commented on a change in pull request #18576: [SPARK-21351][SQL] Update nullability based on children's output
URL: https://github.com/apache/spark/pull/18576#discussion_r244025785
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ##########
 @@ -153,7 +153,9 @@ abstract class Optimizer(sessionCatalog: SessionCatalog)
       RewritePredicateSubquery,
       ColumnPruning,
       CollapseProject,
-      RemoveRedundantProject)
+      RemoveRedundantProject) :+
+    Batch("UpdateAttributeReferences", Once,
+      UpdateNullabilityInAttributeReferences)
 
 Review comment:
   `UpdateNullabilityInAttributeReferences ` is an optimizer rule that was added after we introduced the analyzer rule `FixNullability`. Do we have any end-to-end test case for showing the benefit of this optimizer rule?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org