You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "Junbo-Zheng (via GitHub)" <gi...@apache.org> on 2026/09/11 06:06:37 UTC

[PR] cmake: fix savedefconfig semicolon decoding on wrong variable [nuttx]

Junbo-Zheng opened a new pull request, #20109:
URL: https://github.com/apache/nuttx/pull/20109

   ## Summary
   
   The arch-line filter in `cmake/savedefconfig.cmake` encodes semicolons in `NameAndValue` (to survive CMake list iteration), but then decoded a never-assigned `Value` variable before appending the line to the defconfig. As a result, any matched  CONFIG_ARCH*` value containing a semicolon was written to the generated defconfig with literal `__SEMICOLON__` placeholders instead of the real characters. Decode `NameAndValue` itself.
   
   No in-tree defconfig currently carries a semicolon in an arch value, so this is latent; the fix changes nothing for existing configs and only makes the intended path work.
   
   ## Impact
   
   - **Users**: None -- no in-tree defconfig is affected; only configs with semicolons in `CONFIG_ARCH*` values, which were previously corrupted, are now emitted verbatim.
   - **Build**: None -- the savedefconfig helper only.
   - **Hardware**: None.
   - **Documentation**: None.
   - **Security & Compatibility**: None.
   
   ## Testing
   
   feeding `CONFIG_ARCH_BOARD_CUSTOM_NAME="a;b;c"`:
   
   Before:
   ```
   CONFIG_ARCH_BOARD_CUSTOM_NAME="a__SEMICOLON__b__SEMICOLON__c"
   ```
   After:
   ```
   CONFIG_ARCH_BOARD_CUSTOM_NAME="a;b;c"
   ```
   
   Signed-off-by: Junbo Zheng <[zhengjunbo1@xiaomi.com](mailto:zhengjunbo1@xiaomi.com)>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] cmake: fix savedefconfig semicolon decoding on wrong variable [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #20109:
URL: https://github.com/apache/nuttx/pull/20109


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] cmake: fix savedefconfig semicolon decoding on wrong variable [nuttx]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20109:
URL: https://github.com/apache/nuttx/pull/20109#issuecomment-5630296772

   <!-- membrowse-pr-comment -->
   ## <img src="https://membrowse.com/membrowse-logo.svg" height="24" align="top"> MemBrowse Memory Report
   
   *No memory changes detected for:*
   - [arduino-mega2560](https://membrowse.com/public/apache/nuttx/target/arduino-mega2560/compare?head=aaf238c2ca8ad255fdfb7ce4f036fe6c122fe768&base=28fe1fab72fba19ad9e2fd75c8189cf4ac2e2121)
   - [esp32-devkitc](https://membrowse.com/public/apache/nuttx/target/esp32-devkitc/compare?head=aaf238c2ca8ad255fdfb7ce4f036fe6c122fe768&base=28fe1fab72fba19ad9e2fd75c8189cf4ac2e2121)
   - [hifive1-revb](https://membrowse.com/public/apache/nuttx/target/hifive1-revb/compare?head=aaf238c2ca8ad255fdfb7ce4f036fe6c122fe768&base=28fe1fab72fba19ad9e2fd75c8189cf4ac2e2121)
   - [mirtoo](https://membrowse.com/public/apache/nuttx/target/mirtoo/compare?head=aaf238c2ca8ad255fdfb7ce4f036fe6c122fe768&base=28fe1fab72fba19ad9e2fd75c8189cf4ac2e2121)
   - [qemu-armv8a](https://membrowse.com/public/apache/nuttx/target/qemu-armv8a/compare?head=aaf238c2ca8ad255fdfb7ce4f036fe6c122fe768&base=28fe1fab72fba19ad9e2fd75c8189cf4ac2e2121)
   - [qemu-intel64](https://membrowse.com/public/apache/nuttx/target/qemu-intel64/compare?head=aaf238c2ca8ad255fdfb7ce4f036fe6c122fe768&base=28fe1fab72fba19ad9e2fd75c8189cf4ac2e2121)
   - [rx65n-rsk2mb](https://membrowse.com/public/apache/nuttx/target/rx65n-rsk2mb/compare?head=aaf238c2ca8ad255fdfb7ce4f036fe6c122fe768&base=28fe1fab72fba19ad9e2fd75c8189cf4ac2e2121)
   - [s698pm-dkit](https://membrowse.com/public/apache/nuttx/target/s698pm-dkit/compare?head=aaf238c2ca8ad255fdfb7ce4f036fe6c122fe768&base=28fe1fab72fba19ad9e2fd75c8189cf4ac2e2121)
   - [stm32-nucleo-f103rb](https://membrowse.com/public/apache/nuttx/target/stm32-nucleo-f103rb/compare?head=aaf238c2ca8ad255fdfb7ce4f036fe6c122fe768&base=28fe1fab72fba19ad9e2fd75c8189cf4ac2e2121)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org