You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/01/24 22:54:04 UTC
[GitHub] [iceberg] natsukawa-kanou opened a new pull request #3967: AWS: fix Glue catalog integration test for unknown commit status
natsukawa-kanou opened a new pull request #3967:
URL: https://github.com/apache/iceberg/pull/3967
#3717 changed the exception in Glue integration test. Fix test name and behavior.
@jackye1995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #3967: AWS: fix Glue catalog for unknown commit status
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #3967:
URL: https://github.com/apache/iceberg/pull/3967#issuecomment-1020710238
Thanks, merged!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #3967: AWS: fix Glue catalog integration test for unknown commit status
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #3967:
URL: https://github.com/apache/iceberg/pull/3967#issuecomment-1020636435
thanks, this overall looks good to me, checking AWS integ test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #3967: AWS: fix Glue catalog integration test for unknown commit status
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #3967:
URL: https://github.com/apache/iceberg/pull/3967#issuecomment-1020636435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #3967: AWS: fix Glue catalog integration test for unknown commit status
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #3967:
URL: https://github.com/apache/iceberg/pull/3967#issuecomment-1020659446
Please keep the original `testFailedCommit` to check the CommitFailedException case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 merged pull request #3967: AWS: fix Glue catalog for unknown commit status
Posted by GitBox <gi...@apache.org>.
jackye1995 merged pull request #3967:
URL: https://github.com/apache/iceberg/pull/3967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #3967: AWS: fix Glue catalog integration test for unknown commit status
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #3967:
URL: https://github.com/apache/iceberg/pull/3967#issuecomment-1020667658
Also updating the title to fit the content better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #3967: AWS: fix Glue catalog integration test for unknown commit status
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #3967:
URL: https://github.com/apache/iceberg/pull/3967#issuecomment-1020667500
thanks, running integ test now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #3967: AWS: fix Glue catalog integration test for unknown commit status
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #3967:
URL: https://github.com/apache/iceberg/pull/3967#issuecomment-1020656072
TestGlueCatalogLock fails. I think the issue is that we are not explicitly catching CommitFailedException and it is now falling to the RuntimeException category and identified as unknown status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 merged pull request #3967: AWS: fix Glue catalog for unknown commit status
Posted by GitBox <gi...@apache.org>.
jackye1995 merged pull request #3967:
URL: https://github.com/apache/iceberg/pull/3967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org