[GitHub] [cassandra] adelapena edited a comment on pull request #1321: CASSANDRA-17147 trunk: Guardrails prototype

[GitBox <gi...@apache.org>]

adelapena edited a comment on pull request #1321:
URL: https://github.com/apache/cassandra/pull/1321#issuecomment-984954385


   Thanks for the review. I think I have addressed most of the comments, particularly the ones about dropping those features in the framework that are not used by the included guardrails.
   
   The included guardrails (number of tables, indexes, etc.) were some simple guardrails taken from the CEP to show how the framework is used, so we could place this prototype into a feature branch, and then continue adding more guardrails using the framework, and probably do some final cleanup before merging into trunk.
   
   It seems that instead this has gone in the direction of adding a few guardrails and the (mostly) minimum part of the framework to make them work, so I'm wondering if we should commit this prototype directly to trunk when we are ready, given that it gives us some new features and it doesn't add unneeded code, wdyt?
   
   CI for [j8](https://app.circleci.com/pipelines/github/adelapena/cassandra/1192/workflows/626c0d79-db44-42dd-82f5-f19fe07c1436) and [j11](https://app.circleci.com/pipelines/github/adelapena/cassandra/1192/workflows/f52a6958-a672-4c2c-9e84-930afe01884e).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org