[GitHub] [guacamole-client] mike-jumper commented on a change in pull request #684: GUACAMOLE-1503: Japanese Character input cannot be switched By full-width half-width key.

[GitBox <gi...@apache.org>]

mike-jumper commented on a change in pull request #684:
URL: https://github.com/apache/guacamole-client/pull/684#discussion_r786324227



##########
File path: guacamole-common-js/src/main/webapp/modules/InputSink.js
##########
@@ -118,11 +118,11 @@ Guacamole.InputSink = function InputSink() {
             var rect = focused.getBoundingClientRect();
             if (rect.left + rect.width > 0 && rect.top + rect.height > 0)
                 return;
+                sink.focus();
 
         }
 
         // Refocus input sink instead of handling click
-        sink.focus();

Review comment:
       What's the reasoning behind this change?

##########
File path: guacamole-common-js/src/main/webapp/modules/Keyboard.js
##########
@@ -559,8 +561,7 @@ Guacamole.Keyboard = function Keyboard(element) {
         "Up": [0xFF52],
         "Undo": [0xFF65],
         "Win": [0xFFE7, 0xFFE7, 0xFFE8],
-        "Zenkaku": [0xFF28],
-        "ZenkakuHankaku": [0xFF2A]
+        "Zenkaku": [0xFF28]

Review comment:
       Why is the definition for `ZenkakuHankaku` being removed?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org