[GitHub] [gobblin] homatthew commented on a change in pull request #3477: [GOBBLIN-1619] WriterUtils.mkdirsWithRecursivePermission contains race condition and puts unnecessary load on filesystem

[GitBox <gi...@apache.org>]

homatthew commented on a change in pull request #3477:
URL: https://github.com/apache/gobblin/pull/3477#discussion_r825078113



##########
File path: gobblin-utility/src/main/java/org/apache/gobblin/util/WriterUtils.java
##########
@@ -284,13 +286,7 @@ public static void mkdirsWithRecursivePermissionWithRetry(final FileSystem fs, f
       return;
     }
 
-    if (path.getParent() != null && !fs.exists(path.getParent())) {
-      mkdirsWithRecursivePermissionWithRetry(fs, path.getParent(), perm, retrierConfig);
-    }
-
-    if (!fs.mkdirs(path, perm)) {
-      throw new IOException(String.format("Unable to mkdir %s with permission %s", path, perm));
-    }
+    gobblinMkDirs(fs, path, perm);

Review comment:
       The change itself doesn't change any behavior. What needs to be changed about the javadoc if the change is completely transparent?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org