[GitHub] [hbase] apurtell commented on a change in pull request #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered

[GitBox <gi...@apache.org>]

apurtell commented on a change in pull request #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered
URL: https://github.com/apache/hbase/pull/837#discussion_r347681958
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/BaseReplicationEndpoint.java
 ##########
 @@ -91,7 +92,7 @@ public WALEntryFilter getWALEntryfilter() {
         }
       }
     }
-    return filters.isEmpty() ? null : new ChainWALEntryFilter(filters);
+    return filters.isEmpty() ? null : new ChainWALEntryFilter(filters, this.replicationPeer);
 
 Review comment:
   Is there some other way to do this that does not require adding ReplicationPeer to the method signature? 
   
   Why not create a WALEntryFilter that drops empty cells? Then you can add it to the chain if you want and no further changes are needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services