You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/05/21 07:42:28 UTC
[GitHub] [dubbo-go-pixiu] mark4z commented on a diff in pull request #425: Feat: SpringCloud subscribe strategy and Adapter add enabled config
mark4z commented on code in PR #425:
URL: https://github.com/apache/dubbo-go-pixiu/pull/425#discussion_r878660051
##########
pkg/model/adapter.go:
##########
@@ -19,7 +19,8 @@ package model
// Adapter the adapter plugin for manage cluster or router
type Adapter struct {
- ID string `yaml:"id" json:"id"`
- Name string `yaml:"name" json:"name"` // Name the adapter unique name
- Config map[string]interface{} `yaml:"config" json:"config" mapstructure:"config"` // Config adapter config
+ ID string `yaml:"id" json:"id"`
+ Name string `yaml:"name" json:"name"` // Name the adapter unique name
+ Enabled string `yaml:"enabled" json:"enabled" default:"true"`
Review Comment:
'Enabled' why not bool?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org