You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/05/21 23:05:39 UTC
[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1602: [HUDI-494] fix incorrect record size estimation
nsivabalan commented on a change in pull request #1602:
URL: https://github.com/apache/incubator-hudi/pull/1602#discussion_r428959265
##########
File path: hudi-client/src/test/java/org/apache/hudi/common/HoodieTestDataGenerator.java
##########
@@ -70,7 +70,9 @@
public class HoodieTestDataGenerator {
// based on examination of sample file, the schema produces the following per record size
- public static final int SIZE_PER_RECORD = 50 * 1024;
+ public static final int SIZE_PER_RECORD = (int) (1.2 * 1024);
Review comment:
since you are at it, can we fix the naming. can you add suffix the units for size. whether its bits or bytes.
##########
File path: hudi-client/src/test/java/org/apache/hudi/common/HoodieTestDataGenerator.java
##########
@@ -70,7 +70,9 @@
public class HoodieTestDataGenerator {
// based on examination of sample file, the schema produces the following per record size
- public static final int SIZE_PER_RECORD = 50 * 1024;
+ public static final int SIZE_PER_RECORD = (int) (1.2 * 1024);
Review comment:
same for BLOOM_FILTER_SIZE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org