You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2015/01/20 22:38:42 UTC
Review Request 30097: Ported monitor tests to new interface and made
it type paramed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30097/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Kapil Arya.
Bugs: MESOS-2219
https://issues.apache.org/jira/browse/MESOS-2219
Repository: mesos-git
Description
-------
Ported monitor tests to new monitor interface, changed it to a typed test and wired up monitor module test.
Diffs
-----
src/examples/test_monitor_module.cpp PRE-CREATION
src/tests/monitor_tests.cpp 3b0261946405f9926742a680309880fac7480732
Diff: https://reviews.apache.org/r/30097/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen
Re: Review Request 30097: Monitor modularization [7/7]: Ported
monitor tests to new interface and made it type paramed
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30097/
-----------------------------------------------------------
(Updated Jan. 27, 2015, 2:28 p.m.)
Review request for mesos, Ben Mahler and Kapil Arya.
Bugs: MESOS-2219
https://issues.apache.org/jira/browse/MESOS-2219
Repository: mesos-git
Description
-------
Ported monitor tests to new monitor interface, changed it to a typed test and wired up monitor module test.
Diffs (updated)
-----
src/Makefile.am 07bea1f
src/examples/test_monitor_module.cpp PRE-CREATION
src/tests/module.hpp 21e8fc4
src/tests/module.cpp e6dbf94
src/tests/monitor_tests.cpp 3b02619
Diff: https://reviews.apache.org/r/30097/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen
Re: Review Request 30097: Monitor modularization [7/7]: Ported
monitor tests to new interface and made it type paramed
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30097/
-----------------------------------------------------------
(Updated Jan. 21, 2015, 5:05 p.m.)
Review request for mesos, Ben Mahler and Kapil Arya.
Summary (updated)
-----------------
Monitor modularization [7/7]: Ported monitor tests to new interface and made it type paramed
Bugs: MESOS-2219
https://issues.apache.org/jira/browse/MESOS-2219
Repository: mesos-git
Description
-------
Ported monitor tests to new monitor interface, changed it to a typed test and wired up monitor module test.
Diffs (updated)
-----
src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e
src/examples/test_monitor_module.cpp PRE-CREATION
src/tests/module.hpp 21e8fc4ef9511db35f44d95197077a409ae17eec
src/tests/module.cpp e6dbf94e97dbad46e25c0e4fc79dcbb8c56e5acd
src/tests/monitor_tests.cpp 3b0261946405f9926742a680309880fac7480732
Diff: https://reviews.apache.org/r/30097/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen
Re: Review Request 30097: Monitor modularization [8/8]: Ported
monitor tests to new interface and made it type paramed
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30097/
-----------------------------------------------------------
(Updated Jan. 21, 2015, 2:37 p.m.)
Review request for mesos, Ben Mahler and Kapil Arya.
Summary (updated)
-----------------
Monitor modularization [8/8]: Ported monitor tests to new interface and made it type paramed
Bugs: MESOS-2219
https://issues.apache.org/jira/browse/MESOS-2219
Repository: mesos-git
Description
-------
Ported monitor tests to new monitor interface, changed it to a typed test and wired up monitor module test.
Diffs
-----
src/examples/test_monitor_module.cpp PRE-CREATION
src/tests/monitor_tests.cpp 3b0261946405f9926742a680309880fac7480732
Diff: https://reviews.apache.org/r/30097/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen
Re: Review Request 30097: Ported monitor tests to new interface and
made it type paramed
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30097/#review68801
-----------------------------------------------------------
Ship it!
src/examples/test_monitor_module.cpp
<https://reviews.apache.org/r/30097/#comment113272>
Do we need newlines here?
src/tests/monitor_tests.cpp
<https://reviews.apache.org/r/30097/#comment113273>
newline here?
- Kapil Arya
On Jan. 20, 2015, 4:38 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30097/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2015, 4:38 p.m.)
>
>
> Review request for mesos, Ben Mahler and Kapil Arya.
>
>
> Bugs: MESOS-2219
> https://issues.apache.org/jira/browse/MESOS-2219
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ported monitor tests to new monitor interface, changed it to a typed test and wired up monitor module test.
>
>
> Diffs
> -----
>
> src/examples/test_monitor_module.cpp PRE-CREATION
> src/tests/monitor_tests.cpp 3b0261946405f9926742a680309880fac7480732
>
> Diff: https://reviews.apache.org/r/30097/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Niklas Nielsen
>
>