You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by pe...@apache.org on 2021/11/18 06:27:27 UTC

[pulsar] 04/15: Reduced severity of log "refreshing key manager" in KeyManagerProxy (#12594)

This is an automated email from the ASF dual-hosted git repository.

penghui pushed a commit to branch branch-2.8
in repository https://gitbox.apache.org/repos/asf/pulsar.git

commit 3657203fe9ab783eff0991033254dd7ea4b0982a
Author: Matteo Merli <mm...@apache.org>
AuthorDate: Tue Nov 2 21:04:59 2021 -0700

    Reduced severity of log "refreshing key manager" in KeyManagerProxy (#12594)
    
    (cherry picked from commit b22c55af2736fbc5ddbe75def298c3e74d60f418)
---
 .../main/java/org/apache/pulsar/common/util/KeyManagerProxy.java | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/pulsar-common/src/main/java/org/apache/pulsar/common/util/KeyManagerProxy.java b/pulsar-common/src/main/java/org/apache/pulsar/common/util/KeyManagerProxy.java
index b7b5173..09413af 100644
--- a/pulsar-common/src/main/java/org/apache/pulsar/common/util/KeyManagerProxy.java
+++ b/pulsar-common/src/main/java/org/apache/pulsar/common/util/KeyManagerProxy.java
@@ -73,20 +73,23 @@ public class KeyManagerProxy extends X509ExtendedKeyManager {
                 TimeUnit.SECONDS);
     }
 
-    public void updateKeyManagerSafely() {
+    private void updateKeyManagerSafely() {
         try {
+            if (log.isDebugEnabled()) {
+                log.debug("refreshing key manager for {} {}", certFile.getFileName(), keyFile.getFileName());
+            }
             updateKeyManager();
         } catch (Exception e) {
             log.warn("Failed to update key Manager for {}, {}", certFile.getFileName(), keyFile.getFileName(), e);
         }
     }
 
-    public void updateKeyManager()
+    private void updateKeyManager()
             throws CertificateException, KeyStoreException, NoSuchAlgorithmException, UnrecoverableKeyException {
         if (keyManager != null && !certFile.checkAndRefresh() && !keyFile.checkAndRefresh()) {
             return;
         }
-        log.info("refreshing key manager for {} {}", certFile.getFileName(), keyFile.getFileName());
+
         X509Certificate certificate;
         PrivateKey privateKey = null;
         KeyStore keyStore;