You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/30 01:11:18 UTC

[GitHub] [apisix] nic-chen commented on a change in pull request #2556: featureļ¼šsupport multi service discovery

nic-chen commented on a change in pull request #2556:
URL: https://github.com/apache/apisix/pull/2556#discussion_r514656355



##########
File path: apisix/discovery/eureka.lua
##########
@@ -66,7 +66,8 @@ local _M = {
 
 
 local function service_info()
-    local host = local_conf.eureka and local_conf.eureka.host
+    local host = local_conf.discovery and
+        local_conf.discovery.eureka and local_conf.discovery.eureka.host

Review comment:
       Could we support different instances for a same type discovery?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org