You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by yo...@apache.org on 2022/08/02 06:26:04 UTC
[bookkeeper] 11/22: add writeThreadQueuedLatency (#3363)
This is an automated email from the ASF dual-hosted git repository.
yong pushed a commit to branch branch-4.15
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
commit ccb0417f6a0a2ecbf0424ceda20f1e06dc219407
Author: LinChen <15...@qq.com>
AuthorDate: Thu Jul 14 23:01:35 2022 +0800
add writeThreadQueuedLatency (#3363)
### Motivation
add writeThreadQueueStats : calculate the time the request stays in the write threadpool queue
(cherry picked from commit 79808dccb084b057f3bb9dbc6ce300bf04443b13)
---
.../org/apache/bookkeeper/bookie/BookKeeperServerStats.java | 1 +
.../java/org/apache/bookkeeper/proto/PacketProcessorBase.java | 2 ++
.../main/java/org/apache/bookkeeper/proto/RequestStats.java | 10 ++++++++++
.../org/apache/bookkeeper/proto/WriteEntryProcessorV3.java | 2 ++
4 files changed, 15 insertions(+)
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookKeeperServerStats.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookKeeperServerStats.java
index 1e245a4dab..5ee006bd08 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookKeeperServerStats.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookKeeperServerStats.java
@@ -46,6 +46,7 @@ public interface BookKeeperServerStats {
// Stats
String ADD_ENTRY_REQUEST = "ADD_ENTRY_REQUEST";
String ADD_ENTRY = "ADD_ENTRY";
+ String WRITE_THREAD_QUEUED_LATENCY = "WRITE_THREAD_QUEUED_LATENCY";
String ADD_ENTRY_REJECTED = "ADD_ENTRY_REJECTED";
String FORCE_LEDGER_REQUEST = "FORCE_LEDGER_REQUEST";
String FORCE_LEDGER = "FORCE_LEDGER";
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBase.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBase.java
index 91f054c005..7121579862 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBase.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBase.java
@@ -152,6 +152,8 @@ abstract class PacketProcessorBase<T extends Request> extends SafeRunnable {
@Override
public void safeRun() {
+ requestProcessor.getRequestStats().getWriteThreadQueuedLatency()
+ .registerSuccessfulEvent(MathUtils.elapsedNanos(enqueueNanos), TimeUnit.NANOSECONDS);
if (!isVersionCompatible()) {
sendResponse(BookieProtocol.EBADVERSION,
ResponseBuilder.buildErrorResponse(BookieProtocol.EBADVERSION, request),
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/RequestStats.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/RequestStats.java
index b12e153b99..e31963edd1 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/RequestStats.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/RequestStats.java
@@ -53,6 +53,7 @@ import static org.apache.bookkeeper.bookie.BookKeeperServerStats.READ_LAST_ENTRY
import static org.apache.bookkeeper.bookie.BookKeeperServerStats.SERVER_SCOPE;
import static org.apache.bookkeeper.bookie.BookKeeperServerStats.WRITE_LAC;
import static org.apache.bookkeeper.bookie.BookKeeperServerStats.WRITE_LAC_REQUEST;
+import static org.apache.bookkeeper.bookie.BookKeeperServerStats.WRITE_THREAD_QUEUED_LATENCY;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicInteger;
@@ -92,6 +93,14 @@ public class RequestStats {
parent = ADD_ENTRY_REQUEST
)
private final OpStatsLogger addEntryStats;
+
+ @StatsDoc(
+ name = WRITE_THREAD_QUEUED_LATENCY,
+ help = "operation stats of enqueuing requests to write threadpool queue",
+ parent = ADD_ENTRY_REQUEST
+ )
+ private final OpStatsLogger writeThreadQueuedLatency;
+
@StatsDoc(
name = ADD_ENTRY_REJECTED,
help = "Counter for rejected adds on a bookie",
@@ -240,6 +249,7 @@ public class RequestStats {
public RequestStats(StatsLogger statsLogger) {
this.addEntryStats = statsLogger.getThreadScopedOpStatsLogger(ADD_ENTRY);
+ this.writeThreadQueuedLatency = statsLogger.getThreadScopedOpStatsLogger(WRITE_THREAD_QUEUED_LATENCY);
this.addRequestStats = statsLogger.getOpStatsLogger(ADD_ENTRY_REQUEST);
this.addEntryRejectedCounter = statsLogger.getCounter(ADD_ENTRY_REJECTED);
this.readEntryStats = statsLogger.getThreadScopedOpStatsLogger(READ_ENTRY);
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessorV3.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessorV3.java
index 597c54cf6a..2e6c18c7a8 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessorV3.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessorV3.java
@@ -163,6 +163,8 @@ class WriteEntryProcessorV3 extends PacketProcessorBaseV3 {
@Override
public void safeRun() {
+ requestProcessor.getRequestStats().getWriteThreadQueuedLatency()
+ .registerSuccessfulEvent(MathUtils.elapsedNanos(enqueueNanos), TimeUnit.NANOSECONDS);
AddResponse addResponse = getAddResponse();
if (null != addResponse) {
// This means there was an error and we should send this back.