You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by shazron <gi...@git.apache.org> on 2016/08/31 02:22:38 UTC
[GitHub] cordova-ios pull request #246: CB-11712 - changes in config.xml does ...
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/246
CB-11712 - <name> changes in config.xml does a 'search and replace all' for occurrences of the old name with the new name in the pbxproj
The error message looks like this:
```
Error: The product name change (<name> tag) in config.xml is not supported dynamically.
To change your product name, you have to remove, then add your ios platform again.
Make sure you save your plugins beforehand using `cordova plugin save`.
cordova plugin save
cordova platform rm ios
cordova platform add ios
```
Not sure if I'm supposed to be hardcoding `cordova` for downstream distributions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-ios CB-11712
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/246.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #246
----
commit 5ec6fecf889f7050055d423dd89d5418c5a93865
Author: Shazron Abdullah <sh...@apache.org>
Date: 2016-08-31T02:20:39Z
CB-11712 - <name> changes in config.xml does a 'search and replace all' for occurrences of the old name with the new name in the pbxproj
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #246: CB-11712 - changes in config.xml does a 'sear...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/246
Tests pass, squashing the commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #246: CB-11712 - changes in config.xml does a 'sear...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/246
I am fixing the tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #246: CB-11712 - changes in config.xml does ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/246
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #246: CB-11712 - changes in config.xml does a 'sear...
Posted by bromeostasis <gi...@git.apache.org>.
Github user bromeostasis commented on the issue:
https://github.com/apache/cordova-ios/pull/246
@shazron just updated cordova and started running into this error. We use cordova to apply one codebase to several different white labeled apps with different data and styles.
Until now we've been dynamically changing the name by removing/re-adding the platform we're working on and then using different sets of config.xml/stylesheet/js config. Is there any way to continue this type of behavior, or will we have to create separate cordova projects for each of our White Labels? This would be a serious pain considering we have over 20!!
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #246: CB-11712 - changes in config.xml does a 'sear...
Posted by bromeostasis <gi...@git.apache.org>.
Github user bromeostasis commented on the issue:
https://github.com/apache/cordova-ios/pull/246
@jcesarmobile well I'm running into the expected error:
```
Error: The product name change (<name> tag) in config.xml is not supported dynamically.
To change your product name, you have to remove, then add your ios platform again.
Make sure you save your plugins beforehand using `cordova plugin save`.
cordova plugin save
cordova platform rm ios
cordova platform add ios
```
which I understand the purpose of. We definitely were switching out the \<name\> tag to change the name of the project. I'm just wondering if there's any way to switch the name of the project dynamically with the latest version of cordova, since that's one of our main reasons for using it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #246: CB-11712 - changes in config.xml does a 'sear...
Posted by bromeostasis <gi...@git.apache.org>.
Github user bromeostasis commented on the issue:
https://github.com/apache/cordova-ios/pull/246
@jcesarmobile sure, I'll confirm the specific steps and then post a new issue. Any thoughts on a workaround if this a problem?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #246: CB-11712 - changes in config.xml does a 'sear...
Posted by bromeostasis <gi...@git.apache.org>.
Github user bromeostasis commented on the issue:
https://github.com/apache/cordova-ios/pull/246
@jcesarmobile I found a few bugs on our end that prevented things from working right; looks like the upgrade just exposed those, so no problems here!
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #246: CB-11712 - changes in config.xml does a 'sear...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-ios/pull/246
But you said that you were removing and re adding the platforms, so it shouldn't complain in that case.
This might be related to Cordova CLI 7 also using the package.json for storing the platforms. Can you create a new issue on http://issues.cordova.io/?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #246: CB-11712 - changes in config.xml does a 'sear...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/246
## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/246?src=pr) is 52.67% (diff: 100%)
> Merging [#246](https://codecov.io/gh/apache/cordova-ios/pull/246?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will decrease coverage by **0.82%**
```diff
@@ master #246 diff @@
==========================================
Files 12 12
Lines 1028 1008 -20
Methods 145 145
Messages 0 0
Branches 169 169
==========================================
- Hits 550 531 -19
+ Misses 478 477 -1
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [582e357...c9cb039](https://codecov.io/gh/apache/cordova-ios/compare/582e35776f01ee03f32f0986de181bcf5eb4d232...c9cb039227e01d115e0fb6cfd56a1ad9bbc9ebd8?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #246: CB-11712 - changes in config.xml does a 'sear...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-ios/pull/246
What is your error exactly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #246: CB-11712 - changes in config.xml does a 'sear...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-ios/pull/246
only downgrade to previous CLI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org