You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2018/06/19 22:32:35 UTC
[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build
Hello Henry Robinson, Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10760
to review the following change.
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
......................................................................
IMPALA-4669: [KRPC] Add kudu_rpc library to build
Import FindKRPC.cmake from Apache Kudu.
Add some files to protoc-gen-krpc link to allow it to find symbols now
defined within Impala (without linking all of Impala's libraries).
Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Reviewed-on: http://gerrit.cloudera.org:8080/5719
Reviewed-by: Henry Robinson <he...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/kudu/rpc/CMakeLists.txt
1 file changed, 10 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/10760/1
--
To view, visit http://gerrit.cloudera.org:8080/10760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Gerrit-Change-Number: 10760
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Henry Robinson, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10760
to look at the new patch set (#2).
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
......................................................................
IMPALA-4669: [KRPC] Add kudu_rpc library to build
Import FindKRPC.cmake from Apache Kudu.
Add some files to protoc-gen-krpc link to allow it to find symbols now
defined within Impala (without linking all of Impala's libraries).
Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Reviewed-on: http://gerrit.cloudera.org:8080/5719
Reviewed-by: Henry Robinson <he...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/kudu/rpc/CMakeLists.txt
M be/src/rpc/impala-service-pool.cc
M be/src/rpc/rpc-mgr-test-base.h
M be/src/runtime/krpc-data-stream-mgr.cc
4 files changed, 13 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/10760/2
--
To view, visit http://gerrit.cloudera.org:8080/10760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Gerrit-Change-Number: 10760
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has removed Henry Robinson from this change. ( http://gerrit.cloudera.org:8080/10760 )
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
......................................................................
Removed reviewer Henry Robinson.
--
To view, visit http://gerrit.cloudera.org:8080/10760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Gerrit-Change-Number: 10760
Gerrit-PatchSet: 7
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10760 )
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Gerrit-Change-Number: 10760
Gerrit-PatchSet: 8
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Jul 2018 17:45:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10760 )
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
......................................................................
Patch Set 13: Code-Review+2
Fixed shared linking, carrying Michael's +2
--
To view, visit http://gerrit.cloudera.org:8080/10760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Gerrit-Change-Number: 10760
Gerrit-PatchSet: 13
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jul 2018 17:24:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10760 )
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
......................................................................
Patch Set 13: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Gerrit-Change-Number: 10760
Gerrit-PatchSet: 13
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jul 2018 21:35:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10760 )
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
......................................................................
Patch Set 11: Code-Review+2
Rebased, carrying Michael's +2.
--
To view, visit http://gerrit.cloudera.org:8080/10760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Gerrit-Change-Number: 10760
Gerrit-PatchSet: 11
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Jul 2018 22:04:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Henry Robinson, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10760
to look at the new patch set (#9).
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
......................................................................
IMPALA-4669: [KRPC] Add kudu_rpc library to build
NOTE: This commit is part of a set of changes for IMPALA-7006. It
contains pieces of a previous commit that need to be cherry picked
again after rebasing the code in be/src/kudu/{util,security,rpc}.
The original commit message is below:
Import FindKRPC.cmake from Apache Kudu.
Add some files to protoc-gen-krpc link to allow it to find symbols now
defined within Impala (without linking all of Impala's libraries).
Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Reviewed-on: http://gerrit.cloudera.org:8080/5719
Reviewed-by: Henry Robinson <he...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/kudu/rpc/CMakeLists.txt
M be/src/rpc/impala-service-pool.cc
M be/src/rpc/rpc-mgr-test-base.h
M be/src/runtime/krpc-data-stream-mgr.cc
4 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/10760/9
--
To view, visit http://gerrit.cloudera.org:8080/10760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Gerrit-Change-Number: 10760
Gerrit-PatchSet: 9
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Henry Robinson, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10760
to look at the new patch set (#13).
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
......................................................................
IMPALA-4669: [KRPC] Add kudu_rpc library to build
NOTE: This commit is part of a set of changes for IMPALA-7006. It
contains pieces of a previous commit that need to be cherry picked
again after rebasing the code in be/src/kudu/{util,security,rpc}.
The original commit message is below:
Import FindKRPC.cmake from Apache Kudu.
Add some files to protoc-gen-krpc link to allow it to find symbols now
defined within Impala (without linking all of Impala's libraries).
Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Reviewed-on: http://gerrit.cloudera.org:8080/5719
Reviewed-by: Henry Robinson <he...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/kudu/rpc/CMakeLists.txt
M be/src/rpc/impala-service-pool.cc
M be/src/rpc/rpc-mgr-test-base.h
M be/src/runtime/krpc-data-stream-mgr.cc
4 files changed, 11 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/10760/13
--
To view, visit http://gerrit.cloudera.org:8080/10760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Gerrit-Change-Number: 10760
Gerrit-PatchSet: 13
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Henry Robinson, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10760
to look at the new patch set (#3).
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
......................................................................
IMPALA-4669: [KRPC] Add kudu_rpc library to build
Import FindKRPC.cmake from Apache Kudu.
Add some files to protoc-gen-krpc link to allow it to find symbols now
defined within Impala (without linking all of Impala's libraries).
Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Reviewed-on: http://gerrit.cloudera.org:8080/5719
Reviewed-by: Henry Robinson <he...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/kudu/rpc/CMakeLists.txt
M be/src/rpc/impala-service-pool.cc
M be/src/rpc/rpc-mgr-test-base.h
M be/src/runtime/krpc-data-stream-mgr.cc
4 files changed, 13 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/10760/3
--
To view, visit http://gerrit.cloudera.org:8080/10760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Gerrit-Change-Number: 10760
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10760 )
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
......................................................................
IMPALA-4669: [KRPC] Add kudu_rpc library to build
NOTE: This commit is part of a set of changes for IMPALA-7006. It
contains pieces of a previous commit that need to be cherry picked
again after rebasing the code in be/src/kudu/{util,security,rpc}.
The original commit message is below:
Import FindKRPC.cmake from Apache Kudu.
Add some files to protoc-gen-krpc link to allow it to find symbols now
defined within Impala (without linking all of Impala's libraries).
Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Reviewed-on: http://gerrit.cloudera.org:8080/5719
Reviewed-by: Henry Robinson <he...@cloudera.com>
Tested-by: Impala Public Jenkins
Reviewed-on: http://gerrit.cloudera.org:8080/10760
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Lars Volker <lv...@cloudera.com>
---
M be/src/kudu/rpc/CMakeLists.txt
M be/src/rpc/impala-service-pool.cc
M be/src/rpc/rpc-mgr-test-base.h
M be/src/runtime/krpc-data-stream-mgr.cc
4 files changed, 11 insertions(+), 2 deletions(-)
Approvals:
Lars Volker: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/10760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Gerrit-Change-Number: 10760
Gerrit-PatchSet: 14
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Henry Robinson, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10760
to look at the new patch set (#10).
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
......................................................................
IMPALA-4669: [KRPC] Add kudu_rpc library to build
NOTE: This commit is part of a set of changes for IMPALA-7006. It
contains pieces of a previous commit that need to be cherry picked
again after rebasing the code in be/src/kudu/{util,security,rpc}.
The original commit message is below:
Import FindKRPC.cmake from Apache Kudu.
Add some files to protoc-gen-krpc link to allow it to find symbols now
defined within Impala (without linking all of Impala's libraries).
Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Reviewed-on: http://gerrit.cloudera.org:8080/5719
Reviewed-by: Henry Robinson <he...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/kudu/rpc/CMakeLists.txt
M be/src/rpc/impala-service-pool.cc
M be/src/rpc/rpc-mgr-test-base.h
M be/src/runtime/krpc-data-stream-mgr.cc
4 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/10760/10
--
To view, visit http://gerrit.cloudera.org:8080/10760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Gerrit-Change-Number: 10760
Gerrit-PatchSet: 10
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Henry Robinson, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10760
to look at the new patch set (#8).
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
......................................................................
IMPALA-4669: [KRPC] Add kudu_rpc library to build
NOTE: This commit is part of a set of changes for IMPALA-7006. It
contains pieces of a previous commit that need to be cherry picked
again after rebasing the code in be/src/kudu/{util,security,rpc}.
The original commit message is below:
Import FindKRPC.cmake from Apache Kudu.
Add some files to protoc-gen-krpc link to allow it to find symbols now
defined within Impala (without linking all of Impala's libraries).
Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Reviewed-on: http://gerrit.cloudera.org:8080/5719
Reviewed-by: Henry Robinson <he...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/kudu/rpc/CMakeLists.txt
M be/src/rpc/impala-service-pool.cc
M be/src/rpc/rpc-mgr-test-base.h
M be/src/runtime/krpc-data-stream-mgr.cc
4 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/10760/8
--
To view, visit http://gerrit.cloudera.org:8080/10760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Gerrit-Change-Number: 10760
Gerrit-PatchSet: 8
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Henry Robinson, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10760
to look at the new patch set (#6).
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
......................................................................
IMPALA-4669: [KRPC] Add kudu_rpc library to build
Import FindKRPC.cmake from Apache Kudu.
Add some files to protoc-gen-krpc link to allow it to find symbols now
defined within Impala (without linking all of Impala's libraries).
Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Reviewed-on: http://gerrit.cloudera.org:8080/5719
Reviewed-by: Henry Robinson <he...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/kudu/rpc/CMakeLists.txt
M be/src/rpc/impala-service-pool.cc
M be/src/rpc/rpc-mgr-test-base.h
M be/src/runtime/krpc-data-stream-mgr.cc
4 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/10760/6
--
To view, visit http://gerrit.cloudera.org:8080/10760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Gerrit-Change-Number: 10760
Gerrit-PatchSet: 6
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10760 )
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
......................................................................
Patch Set 7:
This should be ready for review now.
--
To view, visit http://gerrit.cloudera.org:8080/10760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Gerrit-Change-Number: 10760
Gerrit-PatchSet: 7
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jul 2018 20:17:20 +0000
Gerrit-HasComments: No