[GitHub] [hadoop] zhtttylz commented on a diff in pull request #5875: HDFS-17115. HttpFS Add Support getErasureCodeCodecs API

["zhtttylz (via GitHub)" <gi...@apache.org>]

zhtttylz commented on code in PR #5875:
URL: https://github.com/apache/hadoop/pull/5875#discussion_r1271388732


##########
hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/client/BaseTestHttpFSWith.java:
##########
@@ -2149,6 +2152,44 @@ private void testGetAllEEPolicies() throws Exception {
     }
   }
 
+  private void testGetECCodecs() throws Exception {
+    if (isLocalFS()) {
+      // do not test the testGetECCodecs for local FS.
+      return;
+    }
+    final Path path = new Path("/foo");
+    FileSystem fs = FileSystem.get(path.toUri(), this.getProxiedFSConf());
+    if (fs instanceof DistributedFileSystem) {
+      DistributedFileSystem dfs =
+          (DistributedFileSystem) FileSystem.get(path.toUri(), this.getProxiedFSConf());
+      FileSystem httpFs = this.getHttpFSFileSystem();
+
+      Map<String, String> dfsAllErasureCodingCodecs = dfs.getAllErasureCodingCodecs();
+      Map<String, String> diffErasureCodingCodecs = null;
+
+      if (httpFs instanceof HttpFSFileSystem) {
+        HttpFSFileSystem httpFS = (HttpFSFileSystem) httpFs;
+        diffErasureCodingCodecs = httpFS.getAllErasureCodingCodecs();
+      } else if (httpFs instanceof WebHdfsFileSystem) {
+        WebHdfsFileSystem webHdfsFileSystem = (WebHdfsFileSystem) httpFs;
+        diffErasureCodingCodecs = webHdfsFileSystem.getAllErasureCodingCodecs();
+      } else {
+        Assert.fail(fs.getClass().getSimpleName() +

Review Comment:
   Thanks for your suggestion, I'll make the required code changes promptly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org