[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #747: MINIFICPP-1036 - libarchive extension improvements

[GitBox <gi...@apache.org>]

arpadboda commented on a change in pull request #747: MINIFICPP-1036 - libarchive extension improvements
URL: https://github.com/apache/nifi-minifi-cpp/pull/747#discussion_r401549512
 
 

 ##########
 File path: extensions/libarchive/CompressContent.cpp
 ##########
 @@ -74,7 +80,13 @@ void CompressContent::onSchedule(core::ProcessContext *context, core::ProcessSes
   if (context->getProperty(UpdateFileName.getName(), value) && !value.empty()) {
     org::apache::nifi::minifi::utils::StringUtils::StringToBool(value, updateFileName_);
   }
-  logger_->log_info("Compress Content: Mode [%s] Format [%s] Level [%d] UpdateFileName [%d]", compressMode_, compressFormat_, compressLevel_, updateFileName_);
+  value = "";
+  if (context->getProperty(EncapsulateInTar.getName(), value) && !value.empty()) {
 
 Review comment:
   In case the property has a bool validator and a default value, you can skip the if and the string to bool conversion, just call the bool templated getter. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services