[GitHub] spark pull request #18460: [SPARK-21247][SQL] Allow case-insensitive type eq...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18460#discussion_r125383817
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataType.scala ---
    @@ -79,8 +80,12 @@ abstract class DataType extends AbstractDataType {
        * Check if `this` and `other` are the same data type when ignoring nullability
        * (`StructField.nullable`, `ArrayType.containsNull`, and `MapType.valueContainsNull`).
        */
    -  private[spark] def sameType(other: DataType): Boolean =
    -    DataType.equalsIgnoreNullability(this, other)
    +  private[spark] def sameType(other: DataType, isCaseSensitive: Boolean = true): Boolean =
    --- End diff --
    
    maybe we should not consider field names in `sameType`, @gatorsmile what do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org