You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/03/01 22:33:13 UTC
[GitHub] [cordova-plugin-camera] wifisher opened a new pull request #668: (windows) Fixes apache/cordova-plugin-camera#667
wifisher opened a new pull request #668:
URL: https://github.com/apache/cordova-plugin-camera/pull/668
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Windows
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
The plugin was leaving lots of temporary files around in the local root directory. This PR adds code to delete these temporary files.
<!-- If it fixes an open issue, please link to the issue here. -->
https://github.com/apache/cordova-plugin-camera/issues/667
### Description
<!-- Describe your changes in detail -->
The changes are primarily to add calls to deleteAsync() after a file is no longer needed. It cleans up the original captured picture from the camera after that file has been copied or encoded into a base64 string.
It also places the copy made during rescaling into the temporary folder location instead of the local folder.
### Testing
<!-- Please describe in detail how you tested your changes. -->
I have tested it within my app. Four combinations of options were tested for the getPicture() API:
1. FILE_URI and resize
2. FILE_URI and no resize
3. DATA_URI and resize
4. DATA_URI and no resize.
I also monitored the files stored at the root locations of the local and temporary folder locations to confirm that none of the temporary files were left behind.
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] wifisher commented on pull request #668: (windows) Fixes apache/cordova-plugin-camera#667
Posted by GitBox <gi...@apache.org>.
wifisher commented on pull request #668:
URL: https://github.com/apache/cordova-plugin-camera/pull/668#issuecomment-790951968
It looks like the recently run tests completed successfully. It would be nice to have it merged in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] wifisher commented on pull request #668: (windows) Fixes apache/cordova-plugin-camera#667
Posted by GitBox <gi...@apache.org>.
wifisher commented on pull request #668:
URL: https://github.com/apache/cordova-plugin-camera/pull/668#issuecomment-788339969
Any chance of this PR being merged for the next release?
I think that the Travis issues were test system issues and not issues with these changes. But I'm not sure how to restart the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] breautek commented on pull request #668: (windows) Fixes apache/cordova-plugin-camera#667
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #668:
URL: https://github.com/apache/cordova-plugin-camera/pull/668#issuecomment-788352143
> But I'm not sure how to restart the tests.
I'll restart the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] breautek closed pull request #668: (windows) Fixes apache/cordova-plugin-camera#667
Posted by GitBox <gi...@apache.org>.
breautek closed pull request #668:
URL: https://github.com/apache/cordova-plugin-camera/pull/668
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org