You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/16 14:08:33 UTC
[GitHub] [iotdb] wangchao316 opened a new pull request #5261: [IOTDB-2752] reconstructiing the start and stop command
wangchao316 opened a new pull request #5261:
URL: https://github.com/apache/iotdb/pull/5261
1. Extract TestOnly to the common module. because server and confignode need TestOnly.
2. The startup and add-node, remove-node commands are reconstructed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] CRZbulabula commented on a change in pull request #5261: [IOTDB-2752] reconstructing the start and stop command
Posted by GitBox <gi...@apache.org>.
CRZbulabula commented on a change in pull request #5261:
URL: https://github.com/apache/iotdb/pull/5261#discussion_r828744625
##########
File path: confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeConfCheck.java
##########
@@ -70,10 +70,10 @@ public void checkConfig() throws RepeatConfigurationException, IOException {
}
}
- FileInputStream inputStream = new FileInputStream(specialPropertiesFile);
- specialProperties.load(inputStream);
- checkSpecialProperties();
- inputStream.close();
+ try (FileInputStream inputStream = new FileInputStream(specialPropertiesFile)) {
Review comment:
I think maybe the `try` statement is useless. Because if there occurs an IOException, it will be throwed outside, and the ConfigNode won't be started
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #5261: [IOTDB-2752] reconstructiing the start and stop command
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5261:
URL: https://github.com/apache/iotdb/pull/5261#issuecomment-1069269252
[](https://coveralls.io/builds/47424943)
Coverage decreased (-0.01%) to 65.329% when pulling **c48984532537d611ddef5dde149ba6b27d3694d9 on wangchao316:IOTDB-2752** into **d29ef70755bfbb1993e644f4c45b88ef71c0d2c8 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on a change in pull request #5261: [IOTDB-2752] reconstructing the start and stop command
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on a change in pull request #5261:
URL: https://github.com/apache/iotdb/pull/5261#discussion_r828768780
##########
File path: confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeConfCheck.java
##########
@@ -70,10 +70,10 @@ public void checkConfig() throws RepeatConfigurationException, IOException {
}
}
- FileInputStream inputStream = new FileInputStream(specialPropertiesFile);
- specialProperties.load(inputStream);
- checkSpecialProperties();
- inputStream.close();
+ try (FileInputStream inputStream = new FileInputStream(specialPropertiesFile)) {
Review comment:
closed where it is used. Because we can't control where this method will be called later, if the caller gets an exception and does not kill the process, a link leak will occur.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #5261: [IOTDB-2752] reconstructing the start and stop command
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5261:
URL: https://github.com/apache/iotdb/pull/5261#issuecomment-1069269252
[](https://coveralls.io/builds/47445784)
Coverage increased (+0.05%) to 65.49% when pulling **72acceb63d8e0a685c910b6728c5a98e8365a8fc on wangchao316:IOTDB-2752** into **3c22c124285daaba317341e89682cbd81607d622 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 merged pull request #5261: [IOTDB-2752] reconstructing the start and stop command
Posted by GitBox <gi...@apache.org>.
wangchao316 merged pull request #5261:
URL: https://github.com/apache/iotdb/pull/5261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #5261: [IOTDB-2752] reconstructiing the start and stop command
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5261:
URL: https://github.com/apache/iotdb/pull/5261#issuecomment-1069269252
[](https://coveralls.io/builds/47423765)
Coverage remained the same at 65.344% when pulling **c48984532537d611ddef5dde149ba6b27d3694d9 on wangchao316:IOTDB-2752** into **d29ef70755bfbb1993e644f4c45b88ef71c0d2c8 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #5261: [IOTDB-2752] reconstructing the start and stop command
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5261:
URL: https://github.com/apache/iotdb/pull/5261#issuecomment-1069269252
[](https://coveralls.io/builds/47445812)
Coverage increased (+0.004%) to 65.445% when pulling **72acceb63d8e0a685c910b6728c5a98e8365a8fc on wangchao316:IOTDB-2752** into **3c22c124285daaba317341e89682cbd81607d622 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org