[GitHub] [beam] robertwb commented on a diff in pull request #28542: Disable Javascript UDFs for 2.51.0

["robertwb (via GitHub)" <gi...@apache.org>]

robertwb commented on code in PR #28542:
URL: https://github.com/apache/beam/pull/28542#discussion_r1330782501


##########
sdks/python/apache_beam/yaml/yaml_mapping.py:
##########
@@ -129,14 +149,15 @@ def _as_callable(original_fields, expr, transform_name, language):
 
   _check_mapping_arguments(transform_name, **expr)
 
-  if language == "javascript":
-    return _expand_javascript_mapping_func(original_fields, **expr)
-  elif language == "python":
+  # TODO(yaml) - Disable until JsObjectWrapper can be parsed into Beam Row
+  # if language == "javascript":

Review Comment:
   Maybe we could keep this under "javascript-experimental" to keep our tests running? (I would keep the error message below.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org