You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mark Hindess (JIRA)" <ji...@apache.org> on 2006/04/25 15:34:05 UTC

[jira] Created: (HARMONY-409) native-src/linux.IA32/auth/authnix.c isn't really valid C code

native-src/linux.IA32/auth/authnix.c isn't really valid C code
--------------------------------------------------------------

         Key: HARMONY-409
         URL: http://issues.apache.org/jira/browse/HARMONY-409
     Project: Harmony
        Type: Improvement

  Components: Classlib  
    Reporter: Mark Hindess
    Priority: Trivial
 Attachments: really.change.authnix.to.c.not.cpp.diff

Conversion of authnix.cpp to authnix.c was rather limited - for which I take a significant amount of blame.    For instance, it includes declarations mixed with code.  It should be refactored to make it more portable.  I will attach a patch shortly.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (HARMONY-409) native-src/linux.IA32/auth/authnix.c isn't really valid C code

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-409?page=all ]

Tim Ellison reassigned HARMONY-409:
-----------------------------------

    Assign To: Tim Ellison

> native-src/linux.IA32/auth/authnix.c isn't really valid C code
> --------------------------------------------------------------
>
>          Key: HARMONY-409
>          URL: http://issues.apache.org/jira/browse/HARMONY-409
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Tim Ellison
>     Priority: Trivial
>  Attachments: really.change.authnix.to.c.not.cpp.diff
>
> Conversion of authnix.cpp to authnix.c was rather limited - for which I take a significant amount of blame.    For instance, it includes declarations mixed with code.  It should be refactored to make it more portable.  I will attach a patch shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HARMONY-409) native-src/linux.IA32/auth/authnix.c isn't really valid C code

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-409?page=comments#action_12376317 ] 

Mark Hindess commented on HARMONY-409:
--------------------------------------

Looks good.  Thanks Tim.

> native-src/linux.IA32/auth/authnix.c isn't really valid C code
> --------------------------------------------------------------
>
>          Key: HARMONY-409
>          URL: http://issues.apache.org/jira/browse/HARMONY-409
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Tim Ellison
>     Priority: Trivial
>  Attachments: really.change.authnix.to.c.not.cpp.diff
>
> Conversion of authnix.cpp to authnix.c was rather limited - for which I take a significant amount of blame.    For instance, it includes declarations mixed with code.  It should be refactored to make it more portable.  I will attach a patch shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (HARMONY-409) native-src/linux.IA32/auth/authnix.c isn't really valid C code

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-409?page=all ]
     
Tim Ellison closed HARMONY-409:
-------------------------------


Verified by Mark.


> native-src/linux.IA32/auth/authnix.c isn't really valid C code
> --------------------------------------------------------------
>
>          Key: HARMONY-409
>          URL: http://issues.apache.org/jira/browse/HARMONY-409
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Tim Ellison
>     Priority: Trivial
>  Attachments: really.change.authnix.to.c.not.cpp.diff
>
> Conversion of authnix.cpp to authnix.c was rather limited - for which I take a significant amount of blame.    For instance, it includes declarations mixed with code.  It should be refactored to make it more portable.  I will attach a patch shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (HARMONY-409) native-src/linux.IA32/auth/authnix.c isn't really valid C code

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-409?page=all ]
     
Tim Ellison resolved HARMONY-409:
---------------------------------

    Resolution: Fixed

Thanks Mark,

Patch applied to native-src/linux.IA32/auth/authnix.c at repo revision: 396890.

Please check that the patch was applied as you expected.



> native-src/linux.IA32/auth/authnix.c isn't really valid C code
> --------------------------------------------------------------
>
>          Key: HARMONY-409
>          URL: http://issues.apache.org/jira/browse/HARMONY-409
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Tim Ellison
>     Priority: Trivial
>  Attachments: really.change.authnix.to.c.not.cpp.diff
>
> Conversion of authnix.cpp to authnix.c was rather limited - for which I take a significant amount of blame.    For instance, it includes declarations mixed with code.  It should be refactored to make it more portable.  I will attach a patch shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HARMONY-409) native-src/linux.IA32/auth/authnix.c isn't really valid C code

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-409?page=all ]

Mark Hindess updated HARMONY-409:
---------------------------------

    Attachment: really.change.authnix.to.c.not.cpp.diff

Patch to complete conversion to C.


> native-src/linux.IA32/auth/authnix.c isn't really valid C code
> --------------------------------------------------------------
>
>          Key: HARMONY-409
>          URL: http://issues.apache.org/jira/browse/HARMONY-409
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Priority: Trivial
>  Attachments: really.change.authnix.to.c.not.cpp.diff
>
> Conversion of authnix.cpp to authnix.c was rather limited - for which I take a significant amount of blame.    For instance, it includes declarations mixed with code.  It should be refactored to make it more portable.  I will attach a patch shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira